Page MenuHomePhabricator

Ruby linter should run after patch set submission to every repo that has Ruby code
Closed, ResolvedPublic

Description

In addition to mediawiki/ruby/api[1], at least 15 other repos[2] contain Ruby code. Ruby linter should run for all those repos after every patch set submission.

1: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api
2: https://github.com/wikimedia/mediawiki-selenium#links


Version: wmf-deployment
Severity: normal

Details

Reference
bz63469

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:10 AM
bzimport set Reference to bz63469.

Change 150174 had a related patch set uploaded by Zfilipin:
Deleting all qa/browsertests jobs

https://gerrit.wikimedia.org/r/150174

Change 150177 had a related patch set uploaded by Zfilipin:
Running Ruby linter for ArticleFeedbackv5

https://gerrit.wikimedia.org/r/150177

Change 150189 had a related patch set uploaded by Zfilipin:
Created Ruby lint job for ArticleFeedbackv5

https://gerrit.wikimedia.org/r/150189

Change 150174 merged by jenkins-bot:
Deleting all qa/browsertests jobs

https://gerrit.wikimedia.org/r/150174

Basic ruby syntax check should now be running for all repos that have Ruby code.

The next step is to run a linter.

Dan has suggested rubocop[1]. As far as I can see it is the most popular ruby linter[2].

1: https://rubygems.org/gems/rubocop
2: https://www.ruby-toolbox.com/categories/code_metrics

Change 150189 merged by jenkins-bot:
Running Ruby linter for all repos that have Ruby code

https://gerrit.wikimedia.org/r/150189

Change 150177 merged by jenkins-bot:
Running Ruby linter for all repos that have Ruby code

https://gerrit.wikimedia.org/r/150177

Resolving as fixed. This bug has lived long enough. Will create a new bug for rubocop.