Page MenuHomePhabricator

Write tests for mediawiki_selenium Ruby gem
Closed, ResolvedPublic

Description

In the spirit of "the shoemaker's children go barefoot"[1], mediawiki_selenium[2][3] Ruby gem has no tests, mostly because I just did not know how to test it. I have recently stumbled upon Aruba[4][5] Ruby gem. Similarly to mediawiki_selenium, it contains Cucumber step definitions[6][7] and hooks[8][9]. Unlike mediawiki_selenium, it contains tests[10][11].

Add at least one test to mediawiki_selenium. Do not forget to create a Jenkins job that will run the test(s) after every patch set submission to the repo.

1: https://en.wiktionary.org/wiki/the_shoemaker's_children_go_barefoot
2: https://rubygems.org/gems/mediawiki_selenium
3: https://github.com/wikimedia/mediawiki-selenium
4: https://rubygems.org/gems/aruba
5: https://github.com/cucumber/aruba
6: https://github.com/wikimedia/mediawiki-selenium/tree/master/lib/mediawiki_selenium/step_definitions
7: https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber.rb
8: https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki_selenium/support/hooks.rb
9: https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber/hooks.rb
10: https://github.com/cucumber/aruba/tree/master/spec
11: https://github.com/cucumber/aruba/tree/master/features


Version: wmf-deployment
Severity: normal

Details

Reference
bz63474

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:10 AM
bzimport set Reference to bz63474.
bzimport added a subscriber: Unknown Object (MLST).

Dan, you are working on this, right?

In the env-abstraction-layer branch I've been implementing unit tests as I go,[1] but we could certainly use a handful of functional tests.

[1] https://github.com/wikimedia/mediawiki-selenium/tree/env-abstraction-layer/spec