Page MenuHomePhabricator

Actually support novalue and somevalue snaks in queries (tracking)
Closed, InvalidPublic

Description

I see that there is support for novalue and somevalue snaks in some locations, but it's not complete. For example, ByPropertyValueEntityFinder does not support it, and hence neither API nor special page.


Version: master
Severity: normal
Whiteboard: u=dev c=story p=0

Details

Reference
bz63477

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:10 AM
bzimport set Reference to bz63477.
bzimport added a subscriber: Unknown Object (MLST).

The store already stores non-value snaks. It has no query support for those yet as no code has need for it either. The initial query functionality only allows for property value queries (hence the API is named EntitiesByPropertyValue). More complex queries will be supported after that.

So unless we changed our mind on what we want for our initial query functionality from a product perspective, this should not be picked up any time soon. And if we did change our mind, we should discuss first what we want exactly now.

Adrain: also note that the SimpleQuery special page is only meant to do property value queries. (As is states by the class description.) More complex queries will be supported by a dedicated page (that is, if we allow doing those via a special page at all.)

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).Dec 1 2014, 2:31 PM
Lydia_Pintscher claimed this task.

We decided to not work on this given that the SPARQL endpoint seems to be working well and covering most usecases.