Page MenuHomePhabricator

Huggle Build 1096 - Incorrect block text when indefinitely blocking a user.
Closed, ResolvedPublic

Description

See this edit:

which states:
"You have been indefinitely blocked from editing for indefinite. If you feel this block is unjustified, you may contest it by adding the text {{unblock|your reason here}} below"

Naturally, that should have been "editing for vandalism" or something similar. Blocks on IP editors work like a charm though.


Version: 3.0.0
Severity: enhancement

Details

Reference
bz63495

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:11 AM
bzimport added a project: Huggle.
bzimport set Reference to bz63495.

should be fixed in latest version

It seems this still occurs in Huggle 1183. It doesn't look to be a problem in the template itself - instead it seems that Huggle uses [[Template:Huggle/block]] if an editor is indef blocked (Where it should use [[Template:Huggle/block-indef
]])

if (this->ui->comboBox->currentText() != "indefinite")
{
    blocknotice = Configuration::HuggleConfiguration->ProjectConfig_BlockMessage;
    blocknotice = blocknotice.replace("$1", this->ui->comboBox_2->currentText());
    blocknotice = blocknotice.replace("$2", this->ui->comboBox->currentText());
}else
{
    blocknotice = Configuration::HuggleConfiguration->ProjectConfig_BlockMessageIndef;
    blocknotice = blocknotice.replace("$1", this->ui->comboBox->currentText());
}

it clearly uses indef template, do you have a test case showing that latest huggle does that?

ha there was a bug, it's ok now