Page MenuHomePhabricator

Flow: broken flow table on beta labs
Closed, ResolvedPublic

Description

Gerrit 122865 added a maintenance script (db_patches/patch-add_workflow_type.sql) that did too much, dropping the DB column flow_workflow.workflow_definition_id prematurely. We fixed the script in gerrit 123501 but beta labs somehow ran the buggy version, and now the column is gone causing

Unknown column 'workflow_definition_id' in 'where clause'

There are three ways to fix this on beta labs:

a) Manually add back the DB column the buggy maintenance script dropped. We've already gone through the steps on our labs instance.
b) Drop all the Flow tables and let maintenance scripts re-add them.
c) Write a smart maintenance script that figures out if the column was dropped and adds it back.

a) or b) is quick but will require beta labs DB access by the Flow team... how?

c) we can do on our own, but it's tricky because as I understand it, we really do want to drop that column, but not until gerrit 115576. So the maintenance script has to be smart about whether it applies.


Version: unspecified
Severity: normal
URL: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA

Details

Reference
bz63500

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:12 AM
bzimport set Reference to bz63500.
bzimport added a subscriber: Unknown Object (MLST).

Matthias Mullie repaired the beta labs DB, approach (a).

Old content is visible on Talk:Flow, but currently
http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA only shows recent posts; this is probably a caching issue.