Screenshot 1
Observed in 4.0#10 (installed through Testflight).
Message keys are visible in the attached screenshots.
Version: iOS (alpha)
Severity: normal
Attached:
siebrand | |
Apr 4 2014, 7:55 PM |
F13717: image.jpg | |
Nov 22 2014, 3:15 AM |
Screenshot 1
Observed in 4.0#10 (installed through Testflight).
Message keys are visible in the attached screenshots.
Version: iOS (alpha)
Severity: normal
Attached:
Ok, so doing some research it looks like NSLocalizedString doesn't handle fallback on individual strings the way we expected; we'll have to write a custom function that handles it, such as this example: http://stackoverflow.com/questions/3263859/localizing-strings-in-ios-default-fallback-language/8784451#8784451
Provisional fix in https://gerrit.wikimedia.org/r/#/c/125326/ -- adds MWLocalizedString macro to use in place of NSLocalizedString, which falls back to English instead of to the raw key value if there's a missing localization.
(Tested with es which is currently missing that menu key from the sample, which got filled in in nl)
Will apply on the rest after next big merge from Monte, as some renamed directories will make the auto-merge not pretty probably. :D