http->https rewrite (=prefershttps) also rewrites http search urls for Special:Linksearch
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Merl
	Apr 5 2014, 2:35 PM

Description

With preferhttps option enabled by logged in users

gets redirected to

instead of

The protocol part of the search url argument must not be rewritten.

Version: 1.23.0
Severity: normal
URL: http://de.wikipedia.org/wiki/Spezial:Weblinksuche/http://wikimedia.org

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:17 AM

• bzimport set Reference to bz63573.

• bzimport added a subscriber: Unknown Object (MLST).

str_replace replaced all instead of the first one. A regex replace with ^ at the begin would help here.

Wiki.php around line 537
$redirUrl = str_replace( 'http://', 'https://', $oldUrl );

Change 129925 had a related patch set uploaded by Umherirrender:
http -> https rewrite: Only replace one http by https

Change 129925 merged by jenkins-bot:
http -> https rewrite: Only replace one http by https

successfully merged