Page MenuHomePhabricator

Error when using rollback on autoreverts
Closed, DeclinedPublic

Description

When you use rollback on an autorevert (someone who for example vandalises and reverts themselves), it does mark the edits for patrolled but it gives an error that the undo failed. For example on nl.wikipedia on the page "Moeder Teresa" after rollbacking the last two edits of an anon user of today (7 April):

Ongedaan maken van wijzigingen mislukt.

Het is niet mogelijk om de bewerking van de pagina Moeder Teresa door 109.132.6.51 (overleg | bijdragen) ongedaan te maken. Iemand anders heeft deze pagina al bewerkt of hersteld naar een eerdere versie.

De meest recente bewerking is gemaakt door 109.132.6.51 (overleg | bijdragen).

De bewerkingssamenvatting was: "‎Levensloop".

(It says that the rollback faild and that someone "already editted the page or that the page was restored to an earlier version". This is clearly wrong as the edits were patrolled, but the software says an error was made.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62157

Details

Reference
bz63614

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:20 AM
bzimport set Reference to bz63614.
bzimport added a subscriber: Unknown Object (MLST).

Always patrolling a rollback was requested in bug 62157, the error is only shown because you does not produce a new revision (a null edit). This null edit is now detected and the message is shown.

(In reply to Umherirrender from comment #1)

Always patrolling a rollback was requested in bug 62157, the error is only
shown because you does not produce a new revision (a null edit). This null
edit is now detected and the message is shown.

I'm not sure I understand it completely, but this means it's not a bug at all?

Umherirrender: Could you answer comment 2, please?

(In reply to Trijnstel from comment #2)

(In reply to Umherirrender from comment #1)

Always patrolling a rollback was requested in bug 62157, the error is only
shown because you does not produce a new revision (a null edit). This null
edit is now detected and the message is shown.

I'm not sure I understand it completely, but this means it's not a bug at
all?

I am not sure, which is the best option to have here. Having the message "already rolled" is helpful to have correct feedback for the user, setting patrolling or bot flags for the edits maybe not the best, but that was already there before all the changes. Having no patrolling on error was a feature for user on another wiki, so there seems not best way to have here or only missed documentation of that fact.

You can understand this as feature.

No further response, so marking this as WONTFIX.