Page MenuHomePhabricator

Edit button throws errors when VisualEditor not installed
Closed, ResolvedPublic

Description


Version: unspecified
Severity: normal

Details

Reference
bz63658

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:22 AM
bzimport set Reference to bz63658.
bzimport added a subscriber: Unknown Object (MLST).

Change 124494 had a related patch set uploaded by Jdlrobson:
Only offer VisualEditor if installed and enabled

https://gerrit.wikimedia.org/r/124494

Change 124494 merged by jenkins-bot:
Only offer VisualEditor if installed and enabled

https://gerrit.wikimedia.org/r/124494

I had to revert this change... since the code is loaded asynchronously it will always return false.

  • Bug 63736 has been marked as a duplicate of this bug. ***

Probably the easiest thing to do would be to just check mw.config.get( 'wgVisualEditorConfig' ). If VisualEditor isn't installed, that will return null.

Change 126672 had a related patch set uploaded by Kaldari:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672

Change 126672 merged by jenkins-bot:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672