VisualEditor: Update integration to cope with the new "view on <repo>" tabs on file pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TTO
	Apr 8 2014, 9:39 AM

Description

Log in at http://en.wikipedia.beta.wmflabs.org
Enable VE
Visit http://en.wikipedia.beta.wmflabs.org/wiki/File:ButtonsReversed.png (or any foreign file with no local description page)

You see the following views (tabs):

Read
View on Wikimedia Commons
Create source
Add local description ^beta

Visit http://en.wikipedia.beta.wmflabs.org/wiki/File:Button_hover.svg (or any foreign file with an existing local description page)

You see:

Read
View on Wikimedia Commons
Edit source
Edit local description ^beta
View history

The tab name "Create/Edit source" does not sit well next to "Add/Edit local description ^beta". The wikitext-editing tab needs a better name when viewing foreign files.

Admittedly these tabs were altered in core [1] without consulting the VE people, but of course, it is the responsibility of extension authors to catch up to new core functionality.

[1] Gerrit change 104182

Version: unspecified
Severity: minor

Details

Reference: bz63666

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:23 AM

• bzimport added projects: VE-deploy-2014-04-17, VisualEditor-MediaWiki.

• bzimport set Reference to bz63666.

TTO created this task.Apr 8 2014, 9:39 AM

Sorry that we missed this.

BTW, changes to major MediaWiki semantics (even good ones like this) should really be highlighted on wikitech-l and/or ideally design-l before being implemented and merged. I have a bunch of ideas about how this could have been done more cleanly that it's now too late to try out. :-(

So "Edit source" or "Create source" should become "Edit local description source" or "Add local description source" on file description pages for files in foreign repositories?

(In reply to Alex Monk from comment #2)

So "Edit source" or "Create source" should become "Edit local description
source" or "Add local description source" on file description pages for
files in foreign repositories?

I guess. It's verbose, but then that's really my fault...

Change 124775 had a related patch set uploaded by Alex Monk:
Use updated tab labels on description pages for files in foreign repos

https://gerrit.wikimedia.org/r/124775

Change 124775 merged by jenkins-bot:
Use updated tab labels on description pages for files in foreign repos

https://gerrit.wikimedia.org/r/124775

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:08 AM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:03 PM

Restricted Application added a subscriber: Steinsplitter. · View Herald TranscriptSep 26 2015, 2:03 PM

VisualEditor: Update integration to cope with the new "view on <repo>" tabs on file pagesClosed, ResolvedPublicActions

Description

Details

Event Timeline

VisualEditor: Update integration to cope with the new "view on <repo>" tabs on file pages
Closed, ResolvedPublic
Actions