Page MenuHomePhabricator

When VisualEditor not available, wikitext editor still shows a edit switcher button in toolbar
Closed, ResolvedPublic

Description

To replicate:
Disable VisualEditor and load the editor. Wikitext editor loads but according to toolbar VisualEditor is available.


Version: unspecified
Severity: normal

Details

Reference
bz63689

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM
bzimport set Reference to bz63689.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1913

I can't replicate this. If I disable the VisualEditor and try to load the editor in Alpha mode, the editor won't even load. It gives me an unknown dependency JS error. Looking at the code in editor.js, it doesn't look like it takes into account the possibility of the VisualEditor being disabled (which should probably be filed as a different bug).

If you can replicate this, please post more detailed replication steps.

(In reply to Ryan Kaldari from comment #2)

I can't replicate this. If I disable the VisualEditor and try to load the
editor in Alpha mode, the editor won't even load. It gives me an unknown
dependency JS error. Looking at the code in editor.js, it doesn't look like
it takes into account the possibility of the VisualEditor being disabled
(which should probably be filed as a different bug).

This. x1000.

I brought this up as a comment on a patch in Gerrit[1], along with a possible solution, but there were never any replies.

Right now MobileFrontend editing does not work on non-VE-enabled websites... which includes my dev site :P

Probably worthy of a bug...

[1] https://gerrit.wikimedia.org/r/#/c/124881/

sorry Theo! I missed that. I don't follow comments on merged commits. Can you bring up your questions on bug 63736 and I'll do my best to answer them in next 24hrs!

Ryan see Bug: 63736 this bug was raised after a fix for it was merged that had to be reverted :(

Change 126672 had a related patch set uploaded by Kaldari:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672

Change 126672 merged by jenkins-bot:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672