Page MenuHomePhabricator
Create Task
Maniphest T65768

warning message on article deletion / article moving is not parsed
Closed, ResolvedPublic
Actions

Description

Warning message on article deletion / article moving is not parsed. This results in showing plain wikitext like "'''Warning''': blah blah blah" instead of text in which all wiki-markups are parsed.

I know that it is intended to be like this because the hook "AbortMove" shows text like "You do not have permission to move this page, for the following reason:". Therefore, the text follows it should be the reason, which would be plain text.

However, this just doesn't fit with the purpose of Abusefilter. The moving is aborted not because users don't have permission, but because of abusefilter. Therefore, "You do not have permission to move this page, for the following reason:" should not be displayed, and the warning message should be displayed like message shown in onAPIEditBeforeSave(); that is, it should be parsed.

Details

Reference
bz63768

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:12 AM
• bzimport added a project: AbuseFilter.
• bzimport set Reference to bz63768.
• bzimport added a subscriber: Unknown Object (MLST).
Nullzero created this task.Apr 10 2014, 2:03 PM
Rillke added a comment.Apr 15 2014, 10:07 PM

Created attachment 15112
screenshot of the issue at Commons

Attached:

abusefilter_message_not_parsed_on_page_move.png (832×1 px, 62 KB)

• werdna unsubscribed.Dec 10 2014, 5:27 PM
Amire80 moved this task from Backlog to Internationalization on the AbuseFilter board.May 8 2016, 8:22 AM
Nullzero added a comment.May 8 2016, 8:34 AM

No, Amire80, this is not about i18n. It's about wiki markup parsing.

matej_suchanek updated the task description. (Show Details)Dec 10 2016, 12:54 PM
matej_suchanek added a project: TestMe.
matej_suchanek removed a subscriber: • wikibugs-l-list.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 10 2016, 12:54 PM
Daimona removed a project: TestMe.Jul 14 2018, 1:44 PM
Daimona subscribed.

Status of this bug right now: the message is actually parsed, so templates and wikisyntax are correct, though we still have the "You do not have permission to move this page, for the following reason:" message. However, this is actually intended (more or less): to filter "move" actions we use the MovePageCheckPermissions hook, which is indeed intended to check for user permissions. So actually we would need to change the used hook, but is there one which is suitable for our case?

Daimona mentioned this in T199622: Uniform and improve messages shown in case a filter matched the action.Jul 14 2018, 2:07 PM
Daimona closed this task as Resolved.Oct 21 2018, 10:07 AM
Daimona claimed this task.

The original problem is gone, while for having a cleaner message there's T199622

Daimona mentioned this in T208907: CSRF vulnerability in Special:MovePage.Nov 8 2018, 9:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL