Page MenuHomePhabricator

firstHeading should be marked as in interface language on action=history, action=edit etc
Open, MediumPublic

Description

and use a <span lang="{pageLanguage}"></span> to wrap title text, because text "Editing" is in interface language.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=34514

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:20 AM
bzimport set Reference to bz63880.
bzimport added a subscriber: Unknown Object (MLST).

Change 419405 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] [WIP] Wrap title with an element with class, lang and dir attributes

https://gerrit.wikimedia.org/r/419405

Since rSVEC68b52a77e2fe: Usages of page-langcode dropped for html-user-language-attributes the firstHeading element has the lang and dir attributes of the user interface language instead of the PageViewLanguage. This solves the first part of this task:

<h1 id="firstHeading" class="firstHeading">Editing $1</h1>

is now in user interface language. The second part of this task is to enclose the title itself into an element with lang and dir attributes of the page language:

<h1 id="firstHeading" class="firstHeading">Editing <span dir="{{PageTitleDirection}}" lang="{{PageTitleLanguage}}">$1</span></h1>

The PageTitleLanguage differs to the PageViewLanguage on some places like the MediaWiki namespace, which uses always English titles.