Page MenuHomePhabricator
Create Task
Maniphest T65942

Remove font choices from REL1_23 branch while the implementation is unstable
Closed, ResolvedPublic
Actions

Description

REL1_23 has been branched, and MediaWiki 1.23.0 is expected to be released by the end of May.

http://git.wikimedia.org/log/mediawiki%2Fcore.git/refs%2Fheads%2FREL1_23
http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/076002.html

It contains

[mediawiki/core.git] / skins / vector / variables.less
@content-heading-font-family: "Linux Libertine", Georgia, Times, serif;

Please consider reverting in REL1_23 the font choices for headers applied to the MediaWiki master branch the past weeks. They are known to cause problems and unintended behavior in Chinese / Japanese / Korean, and perhaps other non-Latin scripts. The work to define font choices for MediaWiki is ongoing, and currently it is too unstable and risky to be pushed in an official MediaWiki release.

Once the implementation is settled in the master branch, it can be pushed to the corresponding MediaWiki release.

Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63351

Details

Reference
bz63942

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:24 AM
• bzimport added projects: MW-1.23.0-release, MediaWiki-User-Interface.
• bzimport set Reference to bz63942.
• bzimport added a subscriber: Unknown Object (MLST).
Qgil created this task.Apr 15 2014, 2:36 PM
matmarex added a comment.Apr 15 2014, 7:37 PM

This sounds like a very reasonable thing to do to avoid i18n support regression, especially since 1.23 will be a long-term support release.

• bzimport added a comment.Apr 15 2014, 9:17 PM

swalling wrote:

Per bug 63817 any serif whatsoever will cause some issues for Japanese-speaking users on older versions of IE. That is practically speaking the worst issue; other complaints are more stylistic (e.g. old style numerals feeling weird in CJK, which does not normally have such a style). https://gerrit.wikimedia.org/r/#/c/125760/ should allow us to have our cake and eat it too by providing alternative style declarations for CJK. In the meantime, removing them from the general MediaWiki release seems fine to me, provided this will not impact what is deployed on wmf sites.

gerritbot added a comment.Apr 17 2014, 7:37 PM

Change 127132 had a related patch set uploaded by Nemo bis:
Remove font choices from REL1_23 branch while the implementation is unstable

https://gerrit.wikimedia.org/r/127132

gerritbot added a comment.Apr 17 2014, 7:45 PM

Change 127132 merged by jenkins-bot:
Remove font choices from REL1_23 branch while the implementation is unstable

https://gerrit.wikimedia.org/r/127132

matmarex added a comment.Apr 17 2014, 7:46 PM

Done, for 1.23 release branch only.

Krinkle removed subtasks: T65844: h3 should not be more prominent than h2 headings, T65827: Explore better Korean default fonts, T65817: Provide a workaround to IE's bug that causes the generic "serif" rendered broken.Jan 5 2015, 1:55 AM
Nemo_bis mentioned this in T86363: Remove font choices from REL1_24, REL1_25 and REL1_26 branch while the implementation is unstable.Jan 9 2015, 9:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL