Page MenuHomePhabricator

frame:preprocess and expandTemplate shouldn't count toward execution time
Open, LowPublic

Description

Some modules currently transclude a template whose name depends on parameters received, such as Module:Documentation on enwiki. In these types of cases, the module has to call frame:expandTemplate, but this counts towards Lua's time limit. The change at https://en.wikipedia.org/w/index.php?title=Template:Documentation&diff=605027466&oldid=593265833 was made to work around this behavior. Since there's no time limit on preprocessing text or expanding templates from wikitext, I don't see why there needs to be one from Lua.


See Also: T47684: getExpandedArguments should not count toward the 10-second Lua execution limit

Details

Reference
bz64163

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:21 AM
bzimport added a project: Scribunto.
bzimport set Reference to bz64163.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to Jackmcbarn from comment #0)

Since there's no time limit on preprocessing text or expanding
templates from wikitext, I don't see why there needs to be one from Lua.

That's not exactly a good argument, since the Scribunto time limit is to avoid the situation we have with wikitext where pages will take minutes to parse.

It's not Lua's fault that it takes a long time to expand wikitext. This is intended to facilitate converting things a little at a time, the way the arguments change was. Is the Template:Documentation change really what we want to see everywhere?