Page MenuHomePhabricator

$2 in message "requestaccount-email-body-admin" interpreted incorrectly
Closed, ResolvedPublic

Description

The closing quote of the message merges into the URL inserted with variable $2 thus breaking the link, e.g.

"NewUser" has requested an account and is waiting for confirmation.
The email address has been confirmed. You can confirm the request here "http://www.example.org/Special:ConfirmAccounts".

I have inserted <> into the message for better comprehension. I guess quoting the URL should be done with <...> anyway if at all necessary.


Version: unspecified
Severity: normal

Details

Reference
bz64286

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:12 AM
bzimport set Reference to bz64286.
bzimport added a subscriber: Unknown Object (MLST).

I have authored a change that I believe will fix the issue: https://gerrit.wikimedia.org/r/#/c/129178/

Following http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for the sake of automatic notifications in Bugzilla is welcome :)

Yeah, I was wondering why the bot did not act on this commit. Thought that referencing the bug within the top would do the job. Well, next time ...

The patch does not work out. These nasty quotes are still being added to the link. Thus I abandoned the change.

Aklapper subscribed.

@Aklapper This is quite painful for people since they have to manually manipulate the link provided in the e-mail informing about the request.

This is how it looks and in the second line the "&quot" has to be manually removed in the address-line of the browser

&quot;RequestAccountTest&quot; has requested an account and is waiting for confirmation.
The email address has been confirmed. You can confirm the request here &quot;http://www.example.org/wiki/Special:ConfirmAccounts&quot;.

To cut a long story short. It looks like it may be fixed fairly easily, so this may be something for Google-Codein? Not sure who is dealing with this program.

Ah, figured out how to fix this. Sit tight, will do a pull.

Kghbln assigned this task to Yaron_Koren.

Ah @Yaron_Koren has already done this with this commit and did exactly what just wanted to do. Thus MW 1.26+ will have this fix. Thanks a bunch!