Page MenuHomePhabricator
Create Task
Maniphest T66415

Make Wikibase compatible with HHVM
Closed, ResolvedPublic
Actions

Description

Version: master
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz64415

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateNoneT72716 cannot save badges on Q183 (Germany)
 ResolvedNoneT73519 Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on)
 ResolvedLydia_PintscherT66415 Make Wikibase compatible with HHVM
 ResolvedNoneT74040 [HHVM] Travis is failing for Wikibase tests on HHVM
 ResolvedNoneT67698 Under HHVM: Call to a member function getGuid() on a non-object
 ResolvedNoneT66417 Remove class_alias or fix HHVM issues with class_alias
 ResolvedLydia_PintscherT73295 [HHVM] Get rid of class aliases
 ResolvedNoneT74033 Update DataModelSerialization component to use DM 2.0
 ResolvedNoneT74032 Update InternalSerialization component to use DM 2.0
 ResolvedNoneT74035 Get rid of class aliases usage in data-values/geo
 ResolvedNoneT74034 Update Wikibase.git component to use DM 2.0
 DeclinedthiemowmdeT74042 Get rid of class aliases in diff/diff
 DeclinedthiemowmdeT74043 Remove class aliases from data-values/geo
 ResolvedNoneT74139 Make EntitySuggester compatible with DataModel 2.0
 ResolvedNoneT73508 Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement
 ResolvedNoneT73509 Argument 1 passed to Wikibase\TermSqlIndex::getTermsOfEntity() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given
 ResolvedNoneT73510 Argument 3 passed to Wikibase\LabelDescriptionDuplicateDetector::detectTermConflicts() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given
 ResolvedNoneT71525 [HHVM] Tests for WikibaseDataModel on Travis are failing (due to PHPUnit version used)
 ResolvedJeroenDeDauwT71524 [HHVM] Tests on Travis are failing (due to PHPUnit version used)
 ResolvedLydia_PintscherT71526 [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver)

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:20 AM
• bzimport added projects: MediaWiki-extensions-WikibaseRepository, Tracking-Neverending.
• bzimport set Reference to bz64415.
• bzimport added a subscriber: Unknown Object (MLST).
adrianheine created this task.Apr 25 2014, 7:20 AM
ori added a comment.Sep 26 2014, 6:34 AM

The 1.25wmf1 branch is free of HHVM-specific errors, AFAICT.

aude added a comment.Sep 26 2014, 9:39 AM

we still have issues on 1.25wmf1

I simply tried to view a diff (over many revisions):

https://test.wikidata.org/w/index.php?title=Q6&diff=8305&oldid=5032&uselang=en

In the logs, I see, the second which is mine and should be fixed with backport. I can take care of the first one, also.

Sep 26 09:30:51 mw1017: #012Fatal error: Argument 1 passed to Wikibase\RepoItemLinkGenerator::getEditLinksLink() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given in /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/RepoItemLinkGenerator.php on line 140
Sep 26 09:35:52 mw1017: #012Fatal error: Argument 1 passed to Wikibase\ClaimDifferenceVisualizer::formatPropertyId() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\PropertyId given in /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php on line 276

aude added a comment.Sep 26 2014, 1:10 PM

not yet fixed

JanZerebecki added a comment.Oct 29 2014, 5:48 PM

AFAIK all the actual problems we know of under HHVM were fixed. The dependent bugs are only about cleanups and automated tests.

aude added a comment.Oct 29 2014, 10:33 PM

enabled hhvm again on wikidata as a beta feature and don't see any issues

aude added a comment.Oct 29 2014, 10:34 PM

aaaha, this still depends on things that are still open.

i think this bug is fixed and doesn't depend on the other ones, imho, though

Liuxinyu970226 subscribed.Nov 24 2014, 10:16 AM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:27 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher closed this task as Resolved.Dec 15 2014, 2:37 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher closed subtask T73295: [HHVM] Get rid of class aliases as Resolved.Dec 15 2014, 2:39 PM
Lydia_Pintscher closed subtask T71526: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) as Resolved.
Liuxinyu970226 unsubscribed.Dec 16 2014, 12:12 AM
JeroenDeDauw closed subtask T71524: [HHVM] Tests on Travis are failing (due to PHPUnit version used) as Resolved.Jan 5 2015, 1:06 AM
Ricordisamoa added a project: HHVM.Aug 11 2015, 9:24 PM
Ricordisamoa subscribed.
Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 11 2016, 10:14 PM
• Phabricator_maintenance removed a parent task: T4007: [DO NOT USE] Tracking bug [superseded by #Tracking].Jul 28 2016, 2:33 AM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:41 PM
• Phabricator_maintenance removed a project: Tracking-Neverending.Aug 13 2016, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL