Page MenuHomePhabricator
Create Task
Maniphest T66513

ResourceLoader: Add test to ensure all dependencies have the same targets
Closed, ResolvedPublic
Actions

Description

When a resourceloader module has target 'mobile', all its dependencies must also have target 'mobile'.
Please add a test to ensure this. Thanks.
Same for desktop and mabye for future targets, we are not aware right now.

See gerrit 125426 and gerrit 129977, where a new module does not have the target and breaks MobileFrontend.

Feel free to move it to the right component or close it, when not relevant.

Version: 1.24rc
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64512

Details

Reference
bz64513

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:09 AM
• bzimport added a project: MediaWiki-Core-Tests.
• bzimport set Reference to bz64513.
• bzimport added a subscriber: Unknown Object (MLST).
Umherirrender created this task.Apr 27 2014, 6:31 PM
Krinkle added a comment.Apr 27 2014, 6:34 PM

Sounds good.

gerritbot added a comment.Apr 27 2014, 10:59 PM

Change 130024 had a related patch set (by Bartosz Dziewoński) published:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

gerritbot added a comment.Apr 28 2014, 9:38 PM

Change 130024 abandoned by Bartosz Dziewoński:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

Jdlrobson added a comment.Apr 28 2014, 11:41 PM

Bartosz thanks for having a go. I agree this would be something useful to have - if not a bit tricky to realise :)

Essentially you'd have to go through every module and then resolve every dependency (including parents of dependencies) to ensure it has the same set of targets.

gerritbot added a comment.Jun 26 2014, 5:29 PM

Change 130024 restored by Bartosz Dziewoński:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

gerritbot added a comment.Jul 27 2014, 9:21 PM

Change 130024 merged by jenkins-bot:
ResourceLoader: Test that all module dependencies are satisfiable

https://gerrit.wikimedia.org/r/130024

Umherirrender added a comment.Jul 28 2014, 8:21 AM

was successfully merged

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL