Page MenuHomePhabricator

VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.In the caption of the image add templates/images/cite notes/math/reference
4.Click on "Apply Changes"
5.Now hover over the image

Observed Result:
The highlight boxes for templates/images/cite notes/math/references are appearing as well while highlighting the image

See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62681

Attached:

Screen_Shot_2014-04-28_at_11.30.26_AM.png (466×333 px, 68 KB)

Details

Reference
bz64563

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:13 AM
bzimport set Reference to bz64563.

This did not get resolved with the new image model.Giving it to Moriel .

Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363

Change 134363 merged by jenkins-bot:
[BREAKING CHANGE] Merge ProtectedNode into FocusableNode

https://gerrit.wikimedia.org/r/134363

This seems to be working fine now.There is one single shield appearing over the image even if it has different nodes inside the caption

Verified the fix in test2 running wmf9

Verified the fix in production (en.wiki)