Page MenuHomePhabricator
Create Task
Maniphest T66646

VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit
Closed, ResolvedPublic
Actions

Description

In Vector/1.24wmf2, the "Edit source" tab is not highlighted when editing a page in source mode (no tab is highlighted).

Example:
http://www.mediawiki.org/w/index.php?title=Help:Preferences&action=edit

Version: unspecified
Severity: major

Details

Reference
bz64646

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:18 AM
• bzimport added projects: VE-deploy-2014-05-01, VisualEditor-MediaWiki.
• bzimport set Reference to bz64646.
Eloquence created this task.Apr 30 2014, 3:42 AM
Krinkle added a comment.Apr 30 2014, 12:53 PM

Caused by Ib2e6237483338c8072d5f7919c6459bf7418946a, which overides the 'class' attribute of the original edit tab with 'collapsed'. Thus blowing away the class "selected" that MediaWiki core puts there when on action=edit.

gerritbot added a comment.Apr 30 2014, 1:02 PM

Change 130594 had a related patch set uploaded by Krinkle:
Preserve pre-existing css classes on edit tab link.

https://gerrit.wikimedia.org/r/130594

Krinkle added a comment.Apr 30 2014, 1:03 PM

(For the record, yes, confirmed this is broken in production and on latest master).

Krinkle added a comment.Apr 30 2014, 1:17 PM
  • Bug 64645 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Apr 30 2014, 4:31 PM

Change 130594 merged by jenkins-bot:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130594

gerritbot added a comment.Apr 30 2014, 4:32 PM

Change 130622 had a related patch set uploaded by Jforrester:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622

gerritbot added a comment.Apr 30 2014, 11:05 PM

Change 130622 merged by Catrope:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622

Ryasmeen added a comment.May 6 2014, 9:01 PM

Verified the fix on Production, Betalabs and Test2

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:05 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL