Page MenuHomePhabricator

UI freezes when saving too many snaks
Closed, ResolvedPublic

Description

Under some circumstances, an error is caused in the front-end code that causes freezing the UI when saving a list of snaks. A timing issue seems to be very likely.
This was experienced on wikidata.org adding a seventh snak to a list of reference snaks on a rather small item. I was able to reproduce the error locally adding a 4th snak to a set of reference snaks on a rather huge item and adding a 9th snak on a very small item. Consequently, this might correlate with the overall item size in some way.
The error occurs in wikibase.SnakList.add, the function receives "null" instead of a SnakList object. Apart from solving the actual issue, the mechanism should be more robust since snaklistview.value() that is used to generate the parameter may indeed return "null".


Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=13

Details

Reference
bz64651

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:19 AM
bzimport set Reference to bz64651.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 65694 has been marked as a duplicate of this bug. ***

Change 135498 had a related patch set uploaded by Aude:
Focus snakview variation only when viewState is enabled

https://gerrit.wikimedia.org/r/135498

Change 135498 merged by jenkins-bot:
Focus snakview variation only when viewState is enabled

https://gerrit.wikimedia.org/r/135498

Change 135566 had a related patch set uploaded by Aude:
Focus snakview variation only when viewState is enabled

https://gerrit.wikimedia.org/r/135566

Change 135566 merged by jenkins-bot:
Focus snakview variation only when viewState is enabled

https://gerrit.wikimedia.org/r/135566