Page MenuHomePhabricator
Create Task
Maniphest T66743

Re-use the same instance of SiteSQLStore everywhere.
Closed, ResolvedPublic
Actions

Description

Currently, SiteSQLStore::newInstance() is used in a lot of places that need to look up Sites. This means we have to fetch the site list (~800 entries that need to be uncompressed and deserialized) from memcached (via TCP) over and over.

We should inject the SiteStore where possible, and rely on a application scope singleton in WikibaseRepo resp WikibaseClient in static entry points.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz64743

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:25 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz64743.
• bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.May 2 2014, 11:08 AM
daniel added a comment.May 13 2014, 11:33 AM

marius, can you look into this?

gerritbot added a comment.May 13 2014, 10:09 PM

Change 133179 had a related patch set uploaded by Hoo man:
Avoid SiteSQLStore::newInstance and the deprecated Sites class

https://gerrit.wikimedia.org/r/133179

gerritbot added a comment.May 14 2014, 1:33 PM

Change 133179 merged by jenkins-bot:
Avoid SiteSQLStore::newInstance and the deprecated Sites class

https://gerrit.wikimedia.org/r/133179

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL