This https://gerrit.wikimedia.org/r/#/c/52268/ was never re-enabled.
Version: master
Severity: normal
This https://gerrit.wikimedia.org/r/#/c/52268/ was never re-enabled.
Version: master
Severity: normal
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | matmarex | T29397 Preview of JS/CSS pages should highlight the source code instead of using simple <pre> tags | |||
Resolved | matmarex | T66859 Reenable content model support for Syntaxhighlight |
Because of this, in https://gerrit.wikimedia.org/r/#/c/126843 we patched the wrong function. Also when fixing the right function, it seems the fix doesn't work....
:(
Maybe related: bug 27397?
We should probably explicitly drop compatibility with older MWs on SyntaxHighlight master already.
Plot twist: core support for this was reverted in https://gerrit.wikimedia.org/r/#/c/67860/. The code implementing this in SyntaxHighlight is thus entirely and wholly dead.
There is a revert of the revert pending at https://gerrit.wikimedia.org/r/#/c/67983/.
Change 131447 had a related patch set uploaded by Bartosz Dziewoński:
[DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs
Change 131502 had a related patch set uploaded by Bartosz Dziewoński:
Article: Add entire ParserOutput in showCssOrJsPage() like in view()
(In reply to Gerrit Notification Bot from comment #5)
[DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs
Does work now with the core patch above (and all of its dependencies).
Change 131502 merged by jenkins-bot:
Article: Add RL modules for the ParserOutput when showing CSS/JS page
Change 131447 merged by jenkins-bot:
Use ContentGetParserOutput hook instead of ShowRawCssJs