Page MenuHomePhabricator

display globecoordinate also when precision does not match predefined precisions
Closed, ResolvedPublic

Description

The value does not comply with the property's definition.
The value's data value type "ununserializable" does not match the property's data type's data value type "globecoordinate".

https://www.wikidata.org/wiki/Q16511076
https://www.wikidata.org/wiki/Property:P625


Version: master
Severity: critical
Whiteboard: u=dev c=frontend p=8 s=2014-05-20
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55971
https://bugzilla.wikimedia.org/show_bug.cgi?id=65535

Details

Reference
bz64887

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:16 AM
bzimport set Reference to bz64887.
bzimport added a subscriber: Unknown Object (MLST).

Additional info:

Language is set to en.

It's a JavaScript issue. PHP displays: 47°12'36.72"N, 1°33'53.208"W

Not a browser issue. Can reproduce in all browsers.

On other random encounter:

Der Wert entspricht nicht der Eigenschaftsdefinition.
Der Wertedatenwertetyp „ununserializable” stimmt nicht mit dem Datentypdatenwertetyp „globecoordinate” der Eigenschaft überein.

https://www.wikidata.org/wiki/Q4331849

That might be related to the detected precision being invalid / not one of the defined, fixed precisions; See isValidPrecision() and GlobeCoordinate.PRECISIONS in globeCoordinate.GlobeCoordinate.js of DataValuesJavaScript. The related question is whether to allow any kind of precision in general (which was not the original intention).

  • Bug 62105 has been marked as a duplicate of this bug. ***

We talked about this on the hackathon. These fixed fields probably got in because these are used in the javascript interface to select the precision. This precision is in degrees. The data I'm importing is using dimension (in meters) converted to precision (in degrees).

Maybe the slider can be changed that it offers both in the same sequence? You have to calculate it on the fly based on the coordinates, but that shouldn't be too hard.