Since bug 33837 is open for more than two years, can we get $wgLegacyJavaScriptGlobals = false at least on test wikis so script maintainers can esaily notice any remaining usages of these globals?
Version: wmf-deployment
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56550
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T52039 Proposed changes to default settings (DefaultSettings.php) (tracking) | |||
| Resolved | Ladsgroup | T72470 Remove legacy javascript globals | |||
| Declined | Dereckson | T72366 Set $wgLegacyJavaScriptGlobals = false on ptwiki and ptwikibooks | |||
| Resolved | Jdforrester-WMF | T35837 Set $wgLegacyJavaScriptGlobals = false by default | |||
| Resolved | None | T67011 Set $wgLegacyJavaScriptGlobals = false on test2wiki |
"Test wikis" typically means the phase 0 wikis these days, I think. That's four wikis: testwiki, test2wiki, mediawikiwiki, and testwikidata. Probably makes sense to make this change on those four or tweak the bug summary. :-)
I think it is the same as the default MediaWiki configuration ($wgLegacyJavaScriptGlobals = true):
https://github.com/wikimedia/mediawiki-core/blob/master/includes/DefaultSettings.php#L3241-L3266
Indeed, it is not currently overridden in wmf-config:
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php
Change 139569 had a related patch set uploaded by Withoutaname:
Disable $wgLegacyJavaScriptGlobals for "group0" wikis
Gadget authors have not yet been given a fair chance to migrate their scripts. Disabling this now will needlessly upset users and break actively deployed user applications on mediawiki.org. Given the complex nature of our user scripts (cross-loading from different wikis), we'll definitely need a phase where these emit deprecation notices so that developers have the chance of migrating their scripts *before* we boldly remove it hoping they'll quickly fix it. That's counting on breakage as the means to communicate change and I dont like that.
Right now we have about a dozen other highly visible migrations going on in the front-end. These legacy globals is not one of them. They haven't been announced very publicly, have no deprecation warnings for developers either.
They're also cheap to maintain compatibility for. I wouldn't prioritise pushing for the removal of these in the current MediaWiki release cycle.
I think disabling it anywhere is ahead of the curve right now (we should do announcements and deprecation first), and that curve has not yet started due to other priorities right now.
However if users themselves are volunteering to test on testwikis, I think disabling this on test2wiki only would be fine. We do the same currently for the jQuery Migration (although that has already gone through announcements and deprecation warnings first).
Change 139569 merged by jenkins-bot:
Disable $wgLegacyJavaScriptGlobals for test2wiki