Page MenuHomePhabricator
Create Task
Maniphest T67088

O2. No pagination on history pages
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Flow board history doesn't include the pagination that all other history pages have. At the top and bottom of the history page, there should be a line that says:

(newest | oldest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500)

eg. https://www.mediawiki.org/w/index.php?title=Talk:Flow&action=history has ~300 entries.

It should follow the user-preference set by "rclimit" (default 50, see https://www.mediawiki.org/wiki/Manual:$wgDefaultUserOptions )

Old Trello card: https://trello.com/c/W6JdHICk/482-paginate-the-board-history-2

Details

Reference
bz65088
SubjectRepoBranchLines +/-
Add pagination navbar to top of history page as wellmediawiki/extensions/Flowmaster+10 -2
Add navbar to topic & post historymediawiki/extensions/Flowmaster+60 -21
Add navbar to board history storagemediawiki/extensions/Flowmaster+165 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:13 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz65088.
• bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.May 9 2014, 6:53 PM
• Spage added a comment.May 23 2014, 9:14 AM

I wonder how topic history, e.g. https://www.mediawiki.org/w/index.php?title=Talk:Flow&workflow=rquasteiavkguarf&action=history handles hundreds of changes. Have we had any topics with a ton of activity?

Quiddity added a comment.May 23 2014, 11:08 PM

(In reply to spage from comment #1)

I wonder how topic history, e.g.
<https://www.mediawiki.org/w/index.php?title=Talk:
Flow&workflow=rquasteiavkguarf&action=history> handles hundreds of changes.
Have we had any topics with a ton of activity?

I believe Topic histories are meant to be getting the same makeover that Board histories got (ie. to look like a standard history page.). That's tracked at https://trello.com/c/v9Xad55m/104-topic-history-changes

Quiddity added a comment.Jul 31 2014, 5:50 PM
  • Bug 65090 has been marked as a duplicate of this bug. ***
Quiddity added a comment.Jul 31 2014, 5:51 PM

I'm merging bug 65090 to here, with two comments copied across:

(Quiddity wrote)

This page's History goes back to "05:32, 25 February 2014"
https://www.mediawiki.org/w/index.php?title=Talk:Flow&action=history
but the page itself dates back to "23:24, 11 December 2013"

There are similar problems at other pages, eg.
https://en.wikipedia.org/wiki/Wikipedia_talk:Flow/Developer_test_page
(7 February 2014 vs 3 February 2014)

(bsitu wrote)

This is "expected". We only populate the most recent 500 entries and
display the most recent 300 entries of a board history. Fetching and
displaying all at once is obviously not a good idea. Maybe we could add
pagination to the history, for example, 200 entries per load. This would
require some backend change to support pagination.

Jdlrobson added a comment.Sep 4 2014, 1:32 PM

I'm wondering whether this is an issue from a legal point of view? If I go to see http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow%20QA?action=history I cannot see any history pre-September 3rd (yesterday).

matthiasmullie triaged this task as Medium priority.Dec 10 2014, 4:43 PM
matthiasmullie added a project: Collaboration-Team-Triage.
matthiasmullie set Security to None.
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:26 AM
• DannyH renamed this task from No pagination on history pages to [5] No pagination on history pages.Jan 12 2015, 8:08 PM
• DannyH moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.
Quiddity merged a task: T76817: [2] Paginate the Board History.Jan 12 2015, 8:09 PM
Quiddity added a subscriber: Aklapper.
Quiddity updated the task description. (Show Details)Jan 12 2015, 8:11 PM
• DannyH moved this task from Ready for next sprint to Team discussion on the Collaboration-Team-Triage board.Jan 12 2015, 8:22 PM
• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.Jan 12 2015, 8:24 PM
• DannyH moved this task from Ready for next sprint to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.
• DannyH renamed this task from [5] No pagination on history pages to [5] O2. No pagination on history pages.Jan 12 2015, 9:23 PM
matthiasmullie claimed this task.Jan 14 2015, 3:33 PM
matthiasmullie moved this task from Sprint O (ends Jan 27) to In Development on the Collaboration-Team-Triage board.
• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-P-2015-02-11/q3.Jan 28 2015, 7:15 PM
• Mattflaschen-WMF subscribed.
matthiasmullie moved this task from Sprint P - ends Feb 11 to In Development on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 28 2015, 7:16 PM
• Mattflaschen-WMF moved this task from In Development to Untriaged on the Collaboration-Team-Triage board.Jan 28 2015, 7:18 PM
• Mattflaschen-WMF edited a custom field.Jan 28 2015, 8:20 PM
gerritbot added a project: Patch-For-Review.Jan 29 2015, 1:06 AM
gerritbot subscribed.

Change 187309 had a related patch set uploaded (by Matthias Mullie):
Add navbar to board history storage

https://gerrit.wikimedia.org/r/187309

Patch-For-Review

matthiasmullie added a comment.Jan 29 2015, 1:08 AM

Above is for board history.
Topic history is also different - working on that next.

gerritbot added a comment.Jan 29 2015, 10:56 PM

Change 187606 had a related patch set uploaded (by Matthias Mullie):
Add navbar to topic & post history

https://gerrit.wikimedia.org/r/187606

Patch-For-Review

matthiasmullie added a comment.Jan 29 2015, 10:57 PM

Above patch is for topic & (unused, afaict) post history.

matthiasmullie moved this task from In Development to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 29 2015, 10:57 PM
• DannyH removed a project: Collaboration-Team-Triage.Jan 30 2015, 7:31 PM
• DannyH renamed this task from [5] O2. No pagination on history pages to O2. No pagination on history pages.Feb 4 2015, 11:41 PM
gerritbot added a comment.Feb 5 2015, 10:01 PM

Change 187309 merged by jenkins-bot:
Add navbar to board history storage

https://gerrit.wikimedia.org/r/187309

matthiasmullie mentioned this in rEFLWe5ca4598e621: Add navbar to board history storage.Feb 5 2015, 10:01 PM
gerritbot added a comment.Feb 6 2015, 1:54 AM

Change 187606 merged by jenkins-bot:
Add navbar to topic & post history

https://gerrit.wikimedia.org/r/187606

matthiasmullie mentioned this in rEFLWe4de26489e16: Add navbar to topic & post history.Feb 6 2015, 1:54 AM
• Mattflaschen-WMF added a comment.Feb 6 2015, 1:57 AM

Should we add another navbar to the top, like core does for regular pages? See http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow%20QA?action=history .

This can be done easily.

• Mattflaschen-WMF moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 6 2015, 1:57 AM
Quiddity added a comment.Feb 6 2015, 6:02 AM
In T67088#1020006, @Mattflaschen wrote:

Should we add another navbar to the top, like core does for regular pages? See http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow%20QA?action=history .

This can be done easily.

Yes please.

(Each step closer to the standard, is good.
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=history
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=history&uselang=qqx

gerritbot added a comment.Feb 6 2015, 7:01 AM

Change 188979 had a related patch set uploaded (by Mattflaschen):
Add pagination navbar to top of history page as well

https://gerrit.wikimedia.org/r/188979

Patch-For-Review

• Mattflaschen-WMF added a comment.Feb 6 2015, 7:03 AM

Done (pending review). It's slightly more claustrophobic, IMHO, without the "Compare selected revisions" buttons (which don't really make sense in our context, currently).

However, that doesn't block merging the patch or resolving this bug.

gerritbot added a comment.Feb 6 2015, 10:33 AM

Change 188979 merged by jenkins-bot:
Add pagination navbar to top of history page as well

https://gerrit.wikimedia.org/r/188979

• Mattflaschen-WMF mentioned this in rEFLW0d5d9e187831: Add pagination navbar to top of history page as well.Feb 6 2015, 10:33 AM
• DannyH closed this task as Resolved.Feb 6 2015, 10:14 PM

Works on beta!

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 6 2015, 10:14 PM
Diffusion mentioned this in rMEXT348a568ad9b6: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:25 AM
Diffusion mentioned this in rMEXT3f525e71ad1a: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
• Mattflaschen-WMF mentioned this in rMEXT8a14a076420e: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:26 AM
• RobLa-WMF mentioned this in T882: Converted bugs could link to the original report in static-bugzilla.wikimedia.org.Oct 30 2015, 3:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL