Page MenuHomePhabricator

Should be possible in browser tests to use images with meta data or without meta data
Closed, DeclinedPublic

Description

images with no metadata cause a modal dialog warning from MobileFrontend. Images with meta data do not.
To circumvent this we used chunky_png - should this be a default in the Ruby gem? It would be nice to be able to use the shared upload code in MF.

See http://rdoc.info/gems/chunky_png/frames


Version: unspecified
Severity: enhancement

Details

Reference
bz65274

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:25 AM
bzimport set Reference to bz65274.
bzimport added a subscriber: Unknown Object (MLST).
greg subscribed.

@Jdlrobson: can you give some background here and/or let me know if this is still needed?

This was needed back in the days we supported photo uploads. When uploading a photo without meta data an alert would show reminding the user that they should be uploading license free photos. If it had no meta data no confirm step would show. I wanted to write tests for both cases so was unable to.

Since MobileFrontend has this disabled now this is less of a priority but it may be useful for MediaViewer in some way.

MediaViewer folks: Is this something you want?

Jdlrobson renamed this task from add metadata to ChunkyPNG image to Should be possible in browser tests to use images with meta data or without meta data.Apr 10 2015, 4:53 PM
Jdlrobson updated the task description. (Show Details)

It's not clear to me what this task is about. As for ChunkyPNG, it's useful for testing upload functionality (it's used in various UploadWizard tests), not so useful for MediaViewer, given that metadata extraction happens on the server side.

Should this task be closed?

@Jdlrobson: At the very least can we remove Web-Team-Backlog?

It sounds like this is no longer needed by anyone so sure. @greg feel free to close if it makes sense.

greg claimed this task.