Page MenuHomePhabricator
Create Task
Maniphest T67399

Don't use deprecated features removed in jQuery 1.9
Closed, ResolvedPublic
Actions

Description

Tracking bug for reports of JQMIGRATE calls on Wikimedia wikis.

Version: wmf-deployment
Severity: normal

Details

Reference
bz65399

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedKrinkleT46740 Upgrade jQuery from 1.8.x to 1.11.x
 ResolvedNoneT67399 Don't use deprecated features removed in jQuery 1.9
 ResolvedRillkeT68522 AnonymousI18N.js: JQMIGRATE: jQuery.fn.live() is deprecated
 DeclinedNoneT68520 JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()
 Resolved• santhoshT67400 ULS: Fix "JQMIGRATE: $(html) HTML strings must start with '<' character" in jquery.uls.core.js
 ResolvedEsandersT67404 VisualEditor: Remove use of jQuery.browser
 Resolved• GillesT67428 Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler
 ResolvedmatmarexT67562 PDF Rendering page no longer refreshes
 ResolvedTheDJT67666 LiquidThreads: Fix "JQMIGRATE: jQuery.fn.live() is deprecated"
 ResolvedFoxtrottT67667 SemanticForms: Fix "JQMIGRATE: jQuery.fn.live() is deprecated"
 ResolvedNoneT69356 MarkAsHelpful uses deprecated jQuery functions
 ResolvedSe4598T67804 AbuseFilter: Fix "JQMIGRATE: jQuery.fn.toggle(handler, handler...) is deprecated"
 Resolved• santhoshT70998 ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js
 Resolved• santhoshT68064 ULS: attrName property no longer exposed on jQuery.Event objects in jQuery 1.9
 ResolvedNoneT68097 Remove all uses of jQuery.browser
 Resolved• GillesT68359 MwEmbedSupport and TimedMediaHandler require $wgIncludejQueryMigrate = true; ($.browser)
 ResolvedKrinkleT68365 Lightboxes: cannot read property msie of undefined (jquery.ui)
 ResolvedKrinkleT49076 Upgrade jQuery UI from 1.8 to 1.9
 ResolvedNoneT68376 test2wiki: "Link" and other lightboxes completely empty
 ResolvedNoneT68689 Special:NewPagesFeed on test2wiki hangs forever, throws js error
 ResolvedRillkeT67371 MMV: Fix "JQMIGRATE: jQuery.browser is deprecated" in mmv.base.js
 ResolvedJdforrester-WMFT69282 Cite extension: jQuery Tooltip uses deprecated (to be removed) $.browser
 ResolvedFoxtrottT67668 SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated"
 ResolvedTheDJT67679 LiquidThreads: Remove use of jQuery.browser
 ResolvedNoneT68098 MultimediaViewer: Remove uses of jQuery.browser
 ResolvedKrinkleT68292 jquery.cycle.all.js uses jQuery.browser
 ResolvedKrinkleT71349 WikiLove: Fix "JQMIGRATE: jQuery.fn.attr('checked') may use property instead of attribute"
 DeclinedNoneT71350 WikiLove: Fix "JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()"
 ResolvedmatmarexT69989 [jquery.tipsy] Uses deprecated $.fn.live when using live option
 ResolvedNoneT84996 Buttons requiring a rationale on Curation toolbar appear to be broken
 Resolved• Mattflaschen-WMFT85506 Update extensions maintained by Collaboration team for jQuery 1.9 changes
 ResolvedKrenairT85300 Don't use jQuery's live method in MoodBar
 Resolved• Mattflaschen-WMFT85507 Fix incorrect deserialization of HTML in MoodBar
 Resolved• Mattflaschen-WMFT85508 Fix incorrect deserialization of HTML in Flow
 Resolved• Mattflaschen-WMFT85509 Fix incorrect deserialization of HTML in WikiLove
 Resolved• Mattflaschen-WMFT85511 Fix attr v prop issues in Collaboration team extensions
 Resolved• Mattflaschen-WMFT85512 Stop using 'hover' event string in Collaboration team extensions

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:16 AM
• bzimport added projects: WMF-General-or-Unknown, Tracking-Neverending.
• bzimport set Reference to bz65399.
• bzimport added a subscriber: Unknown Object (MLST).
Krinkle created this task.May 16 2014, 3:35 PM
Krinkle added a comment.May 19 2014, 3:26 PM

Time line:

  • 12 May 2014 (1.24wmf4 [9]): Phase 1 – Instrumentation and logging starts. This will run for 4 weeks (until June 9).
  • 19 May 2014 (1.24wmf5): Phase 2 – "Upgrade and Migrate". This will run for 3 weeks (upto June 9). The instrumentation continues during this period.
  • 1 June 2014 (1.24wmf7) Finalise upgrade.

http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg75735.html

1.24wmf7 will be cut from master on May 30, so must be migrated before that.

https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap#Deployment_schedule

Nemo_bis added a comment.May 23 2014, 8:07 AM

Who/how to test the severity of e.g. bug 65666? We need to know how much jQuery 1.9 would break LQT.

Jdforrester-WMF added a comment.May 23 2014, 4:05 PM

(In reply to Nemo from comment #2)

Who/how to test the severity of e.g. bug 65666? We need to know how much
jQuery 1.9 would break LQT.

On a test instance, pull gerrit 133719 for MW-core to test it.

Nemo_bis added a comment.May 23 2014, 4:08 PM

(In reply to James Forrester from comment #3)

On a test instance, pull Gerrit change #133719 for MW-core to test it.

Spiritosone. In case the "Who" part was unclear, I don't plan to set up a test instance for LQT.

Jdforrester-WMF added a comment.May 23 2014, 4:15 PM

(In reply to Nemo from comment #4)

(In reply to James Forrester from comment #3)

On a test instance, pull Gerrit change #133719 for MW-core to test it.

Spiritosone. In case the "Who" part was unclear, I don't plan to set up a
test instance for LQT.

Then don't ask how when all you care about is 'who'. :-)

Nemo_bis added a comment.May 23 2014, 4:19 PM

(In reply to James Forrester from comment #5)

Then don't ask how when all you care about is 'who'. :-)

The "who" depends on the "how", so don't put words in my mouth.

Krinkle closed subtask T71349: WikiLove: Fix "JQMIGRATE: jQuery.fn.attr('checked') may use property instead of attribute" as Resolved.Nov 25 2014, 5:29 PM
Jdforrester-WMF added a comment.Nov 25 2014, 5:56 PM

Does this mean we're done? No blocking bugs; time for an announcement that we're doing it?

matmarex added a subtask: T69989: [jquery.tipsy] Uses deprecated $.fn.live when using live option.Nov 30 2014, 3:57 PM
Krinkle mentioned this in rEMMVcf486877316a: Migrate jQuery andSelf() to addBack().Dec 10 2014, 5:21 PM
• Mattflaschen-WMF added a subtask: T84996: Buttons requiring a rationale on Curation toolbar appear to be broken.Dec 19 2014, 8:47 PM
• Mattflaschen-WMF subscribed.Dec 19 2014, 8:55 PM

Note, the patch removing jQuery Migrate was c393f8747, merged on December 4. Anything open and blocking this bug is broken on production Wikipedia wikis.

Legoktm closed subtask T84996: Buttons requiring a rationale on Curation toolbar appear to be broken as Resolved.Dec 20 2014, 1:33 AM
• Mattflaschen-WMF closed subtask T69989: [jquery.tipsy] Uses deprecated $.fn.live when using live option as Resolved.Dec 20 2014, 2:29 AM
Quiddity reopened subtask T84996: Buttons requiring a rationale on Curation toolbar appear to be broken as Open.Dec 22 2014, 6:48 PM
• Spage closed subtask T84996: Buttons requiring a rationale on Curation toolbar appear to be broken as Resolved.Dec 23 2014, 1:37 AM
• Spage reopened subtask T84996: Buttons requiring a rationale on Curation toolbar appear to be broken as Open.Dec 23 2014, 3:30 AM
• Mattflaschen-WMF closed subtask T84996: Buttons requiring a rationale on Curation toolbar appear to be broken as Resolved.Dec 24 2014, 6:59 PM
• Mattflaschen-WMF removed a subtask: T85300: Don't use jQuery's live method in MoodBar.Dec 30 2014, 3:57 AM
• DannyH closed subtask T85506: Update extensions maintained by Collaboration team for jQuery 1.9 changes as Resolved.Feb 3 2015, 11:56 PM
• Mattflaschen-WMF closed this task as Resolved.Feb 4 2015, 5:39 AM
• Mattflaschen-WMF set Security to None.
Krinkle mentioned this in rMEXT2a986d8b35b6: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Mar 11 2015, 6:21 AM
Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 11 2016, 10:13 PM
• Phabricator_maintenance removed a parent task: T4007: [DO NOT USE] Tracking bug [superseded by #Tracking].Jul 28 2016, 2:33 AM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:41 PM
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.
• Phabricator_maintenance renamed this task from Don't use deprecated features removed in jQuery 1.9 (tracking) to Don't use deprecated features removed in jQuery 1.9.Aug 13 2016, 9:21 PM
• Phabricator_maintenance removed a project: Tracking-Neverending.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL