Page MenuHomePhabricator

VisualEditor: Disentangle MWSaveDialog and mw.ArticleTarget
Open, MediumPublicFeature

Description

Right now, the way that the save button is disabled when you click it is that MWSaveDialog listens to the button's click event, in response to that it fires the 'save' event, ArticleTarget gets that event, reaches into the save dialog and disables the button.

This is only one of many insane things about the totally dysfunctional MWSaveDialog - ArticleTarget relationship; the whole way these two interact should be refactored.


Version: unspecified
Severity: enhancement

Details

Reference
bz65513

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:25 AM
bzimport added a project: Technical-Debt.
bzimport set Reference to bz65513.

This'd be lovely to get fixed properly. Alex, could you take a look at this at some point? I imagine Roan'd love to be involved in the refactor, though. :-)

Mostly fixed in gerrit 135945 but Roan said there are still some outstanding issues.

Yeah, that patch wasn't really intended to fully fix this.

Change 140868 had a related patch set uploaded by Alex Monk:
Move some stuff from ViewPageTarget to MWSaveDialog

https://gerrit.wikimedia.org/r/140868

Change 140868 abandoned by Alex Monk:
Move some stuff from ViewPageTarget to MWSaveDialog

https://gerrit.wikimedia.org/r/140868

Esanders renamed this task from VisualEditor: Disentangle MWSaveDialog and mw.ViewPageTarget to VisualEditor: Disentangle MWSaveDialog and mw.ArticleTarget.May 31 2020, 12:59 PM
Esanders updated the task description. (Show Details)
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:23 PM