VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	May 20 2014, 8:59 PM

Description

Bug 50047 and bug 51918 have regressed for Firefox – possibly as a result of Ed's changes to how the buttons work? Yay for Firefox and its attitude to tab indexes.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66824

Details

Reference: bz65554

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:09 AM

• bzimport added projects: Browser-Support-Firefox, VE-deploy-2014-07-03, VisualEditor-MediaWiki.

• bzimport set Reference to bz65554.

Jdforrester-WMF created this task.May 20 2014, 8:59 PM

Looks like the same issue as bug 66824

So adding this.reviewButton.$element.attr( 'tabindex', '0' ).find( 'a' ).removeAttr( 'tabindex' ); fixed this... Wtf firefox?

Change 143055 had a related patch set uploaded by Alex Monk:
Set tabindex on button <div> instead of <a>

https://gerrit.wikimedia.org/r/143055

Change 143055 merged by jenkins-bot:
Set tabindex on button <div> instead of <a>

https://gerrit.wikimedia.org/r/143055

Well that's at least a workaround. I wonder if this might be an upstream bug...

Bug 67153 has been marked as a duplicate of this bug. ***

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:01 AM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM

VisualEditor: [Regression] Can't tab to save form dialog buttons in FirefoxClosed, ResolvedPublicActions

Description

Details

Event Timeline

VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox
Closed, ResolvedPublic
Actions