Page MenuHomePhabricator
Create Task
Maniphest T67616

VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

1.Open a oage with VE
2.Insert an image
3.Make it right aligned and framless
4.Hover over it

Observed Result:
It throws the following error:
Uncaught TypeError: Cannot read property 'getSurface' of null

Version: unspecified
Severity: normal

Details

Reference
bz65616

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:13 AM
• bzimport added projects: VE-deploy-2014-05-29, VisualEditor-ContentEditable.
• bzimport set Reference to bz65616.
Ryasmeen created this task.May 21 2014, 11:16 PM
Ryasmeen added a comment.May 22 2014, 5:56 AM

It also happens for the following case:

  1. Change alignment of any image
  2. Delete the image
  3. Observe that, the phantom of the image is still there after deleting the image

4.Now hover over the phantom

Observed Result:
As soon as you delete the image the error: Cannot read property 'getSurface' of null appears, also everytime you hover over the phantom , you will get this same error.

See the screenshot attached

Ryasmeen added a comment.May 22 2014, 5:56 AM

Created attachment 15455
Screenshot

Attached:

Screen_Shot_2014-05-21_at_10.56.12_PM.png (763×815 px, 144 KB)

gerritbot added a comment.May 22 2014, 2:55 PM

Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363

Jdforrester-WMF added a comment.May 22 2014, 9:58 PM

Fixed and backport going out in SWAT.

gerritbot added a comment.May 22 2014, 10:27 PM

Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363

Jdforrester-WMF added a comment.May 22 2014, 11:19 PM

Still fixed.

Ryasmeen added a comment.May 23 2014, 1:24 AM

Verified the fix in Betalabs and test 2

Ryasmeen added a comment.Jun 6 2014, 9:46 PM

Verified the fix in production.

gerritbot added a comment.Jun 10 2014, 11:19 PM

Change 134363 merged by jenkins-bot:
[BREAKING CHANGE] Merge ProtectedNode into FocusableNode

https://gerrit.wikimedia.org/r/134363

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:03 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL