Page MenuHomePhabricator

VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Make it Frameless-right or Basic-Right
4.Hover over the image after that

Observed Result:
The area around the image remains highlighted but not the image itself

See the screenshot attached
Environment: Betalabs


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-05-23_at_4.47.10_PM.png (732×1 px, 228 KB)

Details

Reference
bz65716

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:20 AM
bzimport set Reference to bz65716.

Corrected steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Make it Frameless-Left or Basic-Left
4.Now uncheck the wrapping option.
5.Hover over the image after that.

Observed Result:
The area around the image remains highlighted but not the image itself.

Selection range issue, not a shield issue.

  • This bug has been marked as a duplicate of bug 65706 ***

Change 137040 had a related patch set uploaded by Esanders:
[BREAKING CHANGE (ish)] Track orignal data position in insertion operations

https://gerrit.wikimedia.org/r/137040

Change 139824 had a related patch set uploaded by Esanders:
Fix selection after inserting nodes

https://gerrit.wikimedia.org/r/139824

Change 137040 merged by jenkins-bot:
[BREAKING CHANGE (ish)] Track original data position in insertion operations

https://gerrit.wikimedia.org/r/137040

Change 139824 merged by jenkins-bot:
Fix selection after inserting nodes

https://gerrit.wikimedia.org/r/139824

Change 140687 had a related patch set uploaded by Esanders:
Fix fragment after inserting an image node

https://gerrit.wikimedia.org/r/140687

Change 140687 merged by jenkins-bot:
Fix fragment after inserting an image node

https://gerrit.wikimedia.org/r/140687

Change 140747 had a related patch set uploaded by Jforrester:
Fix fragment after inserting an image node

https://gerrit.wikimedia.org/r/140747

Change 140747 merged by Catrope:
Fix fragment after inserting an image node

https://gerrit.wikimedia.org/r/140747

Verified the fix in production