Author: pr4tiklahoti
Description:
The CSS applied for Special:PageMigration as of now is quite trivial. Input fields, buttons, and other blocks of text need to be styled to meet the standards followed.
Refer: https://gerrit.wikimedia.org/r/#/c/133720/17/resources/css/ext.translate.special.pagemigration.css
Version: unspecified
Severity: enhancement
URL: https://www.mediawiki.org/wiki/Manual:Coding_conventions
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T48645 Tools for mass migration of legacy translated wiki content | ||
| Open | Feature | None | T67740 Special page for migration of legacy translation pages (tracking) | ||
| Resolved | None | T67738 Fix code styling and architecture issues for Special:PageMigration |
Niklas, can you please tell if this was fixed as byproduct of https://gerrit.wikimedia.org/r/135750 / bug 65736 or what else is left to do to comply with [[mw:CC]]?
It's getting better. With some further work and adding some QUnit tests this can be closed. Note that I do not just mean mw:CC but code architecture as well.
Next task defined:
Nikerabbit> BPositive: you can start by creating a function like listen() which adds all the click handlers... try to have the callbacks for those handlers as separate functions so that the listen function itself is very short.Nikerabbit> BPositive: $( document ).ready( listen ); function listen() { var $form = ...; $listing = ...; $listing.on( 'click', ..., someCallbackFunctionName ) }
Change 137406 had a related patch set uploaded by BPositive:
Code architecture fixed for Special:PageMigration
Change 137406 merged by jenkins-bot:
Code architecture fixed for Special:PageMigration
Let's close this one because it has been to vague for the whole time.
Ideally the code would be made a class or jquery plugin following examples in other files.