Page MenuHomePhabricator
Create Task
Maniphest T67915

Flow: Interwiki exceptions from Special:WhatLinksHere
Closed, ResolvedPublic
Actions

Description

It seems asking for WhatLinkshere on one wiki causes exceptions when there are links to it on another wiki.

Happens on enwiki for File:OUYA-Console-set-h.jpg, which I linked on mw.org, also on enwiki for Talk:Sandbox, Template:Bug, etc. But this doesn't happen on meta-wiki which is running the same version, or on mw.org. Confusing.

Perhaps the Flow hook that tries to create a link on WhatLinksHereProp needs to be more robust. Or maybe we need to run maintenance/FlowPopulateLinksTables.php against multiple wikis.

Here's one:

2014-05-29 17:52:55 mw1076 enwiki: [12257f85] /wiki/Special:WhatLinksHere/File:OUYA-Console-set-h.jpg Exception from line 182 of /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/Model/Workflow.php: Interwiki to mediawikiwiki not implemented
#0 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/BaseUrlGenerator.php(171): Flow\Model\Workflow->getArticleTitle()
#1 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/UrlGenerator.php(202): Flow\BaseUrlGenerator->resolveTitle(NULL, Object(Flow\Model\UUID))
#2 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/ReferenceClarifier.php(50): Flow\UrlGenerator->postLink(NULL, Object(Flow\Model\UUID), Object(Flow\Model\UUID))
#3 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/ReferenceClarifier.php(28): Flow\ReferenceClarifier->getObjectLink(Object(Flow\Model\UUID), 'post', Object(Flow\Model\UUID))
#4 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/Hooks.php(620): Flow\ReferenceClarifier->getWhatLinksHereProps(Object(stdClass), Object(Title), Object(Title))
#5 [internal function]: FlowHooks::onWhatLinksHereProps(Object(stdClass), Object(Title), Object(Title), Array)
#6 /usr/local/apache/common-local/php-1.24wmf5/includes/Hooks.php(206): call_user_func_array('FlowHooks::onWh...', Array)
#7 /usr/local/apache/common-local/php-1.24wmf5/includes/GlobalFunctions.php(4004): Hooks::run('WhatLinksHerePr...', Array, NULL)
#8 /usr/local/apache/common-local/php-1.24wmf5/includes/specials/SpecialWhatlinkshere.php(329): wfRunHooks('WhatLinksHerePr...', Array)
#9 /usr/local/apache/common-local/php-1.24wmf5/includes/specials/SpecialWhatlinkshere.php(272): SpecialWhatLinksHere->listItem(Object(stdClass), Object(Title), Object(Title))

Version: master
Severity: major
URL: https://en.wikipedia.org/wiki/Special:WhatLinksHere/File:OUYA-Console-set-h.jpg
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=65802

Details

Reference
bz65915
SubjectRepoBranchLines +/-
Segregate Reference objects by source wiki.mediawiki/extensions/Flowmaster+354 -33
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:16 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz65915.
• Spage created this task.May 29 2014, 9:47 PM
• bzimport added a comment.May 29 2014, 11:08 PM

bsitu wrote:

It seems that we are loading links by namespace/title pair. If a page with the same namespace/title exists in multitple wikis, this would load unwanted data from other wikis. I think this could be resolved in two steps:

  1. Catch the exception and ignore unrelated reference
  1. Add a wiki field to flow_wiki_ref so only to load reference for the page in current wiki, remove the exception in step 1.
gerritbot added a comment.May 29 2014, 11:39 PM

Change 136256 had a related patch set uploaded by Bsitu:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136256

• werdna added a comment.May 30 2014, 4:35 AM
  • Bug 65802 has been marked as a duplicate of this bug. ***
gerritbot added a comment.May 30 2014, 5:08 AM

Change 136280 had a related patch set uploaded by Werdna:
Segregate Reference objects by source wiki.

https://gerrit.wikimedia.org/r/136280

Aklapper added a comment.May 30 2014, 6:52 AM
  • Bug 65802 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Jun 2 2014, 9:55 AM

Change 136256 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136256

gerritbot added a comment.Jun 2 2014, 10:38 PM

Change 136932 had a related patch set uploaded by Spage:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136932

gerritbot added a comment.Jun 2 2014, 10:39 PM

Change 136932 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136932

gerritbot added a comment.Jun 2 2014, 10:40 PM

Change 136933 had a related patch set uploaded by Spage:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136933

gerritbot added a comment.Jun 2 2014, 10:45 PM

Change 136933 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136933

• Spage added a comment.Jun 12 2014, 12:32 AM

We're no longer getting these. We're getting Flow Interwiki exceptions from certain Special:Contributions

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:34 AM
gerritbot subscribed.Jul 28 2015, 8:30 PM

Change 136280 had a related patch set uploaded (by Mattflaschen):
Segregate Reference objects by source wiki.

https://gerrit.wikimedia.org/r/136280

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 28 2015, 8:30 PM
gerritbot added a project: Patch-For-Review.Jul 28 2015, 8:30 PM
Quiddity moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jul 29 2015, 11:53 PM
Catrope reopened this task as Open.Jul 31 2015, 12:45 AM
Catrope subscribed.

This isn't resolved, the patch was never merged

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2015, 12:45 AM
Catrope closed this task as Resolved.Jul 31 2015, 12:46 AM

Sorry, no, THIS was resolved, but we still have DIFFERENT exceptions on Special:Whatlinkshere, see T107540: Argument 6 passed to Flow\\Model\\WikiReference::__construct() must be an instance of Title, null given at /srv/mediawiki/php-1.26wmf16/extensions/Flow/includes/Model/WikiReference.php:35

gerritbot added a comment.Aug 25 2015, 7:47 PM

Change 136280 merged by jenkins-bot:
Segregate Reference objects by source wiki.

https://gerrit.wikimedia.org/r/136280

Diffusion mentioned this in rMEXT7b44ef714d58: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 25 2015, 7:47 PM
• Mattflaschen-WMF mentioned this in rEFLWf07c6ba71699: Segregate Reference objects by source wiki..Aug 25 2015, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL