Page MenuHomePhabricator
Create Task
Maniphest T68140

WikiCode de + not found+
Closed, ResolvedPublic
Actions

Description

So far twice reported in OTRS. I haven't been able to reproduce this myself (switched device language to German) but it seems that there is an issue with the languages_list.xml table lookup.

The interesting part of the stack trace is:
~~~~
java.lang.RuntimeException: WikiCode de + not found+
at org.wikipedia.WikipediaApp.findWikiIndex(WikipediaApp.java:275)
at org.wikipedia.settings.LanguagePreference.<init>(LanguagePreference.java:26)

git SHA: 5df0d7b3

I think we should consider default to English instead of throwing a RuntimeException in this case.

From OTRS:
2014053010015204: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7580023
2014060410002588: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7587157

Version: Alpha
Severity: normal

Details

Reference
bz66140

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:13 AM
• bzimport added a project: Wikipedia-Android-App-Backlog.
• bzimport set Reference to bz66140.
• bzimport added a subscriber: Unknown Object (MLST).
• bearND created this task.Jun 4 2014, 9:25 PM
• bearND added a comment.Jun 4 2014, 9:48 PM

Also got more reports from other German users in beta1. It was a build issue, which Yuvi fixed in beta2.

yuvipanda added a comment.Jun 5 2014, 1:55 PM

This has been happening for some non de users as well, with weird language codes that we don't have. Updated code to not crash. We need to instrument this to figure out which language codes those are, but 'tis ok for now.

gerritbot added a comment.Jun 5 2014, 1:56 PM

Change 137577 had a related patch set uploaded by Yuvipanda:
Don't crash if we can't find a language code

https://gerrit.wikimedia.org/r/137577

gerritbot added a comment.Jun 5 2014, 1:57 PM

Change 137577 merged by Dbrant:
Don't crash if we can't find a language code

https://gerrit.wikimedia.org/r/137577

• Deskana moved this task from Needs Triage to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Mar 24 2015, 4:47 AM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL