Page MenuHomePhabricator
Create Task
Maniphest T68141

Fatal error when previewing a template that doesn't yet exist
Closed, ResolvedPublic
Actions

Description

On the beta cluster, the page "User:Jackmcbarn/Page" contains "{{A nonexistent template}}" as the content. If you go to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:A_nonexistent_template&action=edit and enter "User:Jackmcbarn/Page" in the page title box, a fatal error will be generated when previewing: PHP fatal error in /srv/common-local/php-master/extensions/TemplateSandbox/TemplateSandbox.hooks.php line 205:
Call to a member function isRedirect() on a non-object

Version: unspecified
Severity: major

Details

Reference
bz66141

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:13 AM
• bzimport added a project: MediaWiki-extensions-TemplateSandbox.
• bzimport set Reference to bz66141.
Jackmcbarn created this task.Jun 4 2014, 9:42 PM
Jackmcbarn added a comment.Jun 4 2014, 9:53 PM

This appears to have been caused by I83cdd4adaaa67f81e933654228eccdc9fcdf9009 in core.

gerritbot added a comment.Jun 5 2014, 12:35 AM

Change 137511 had a related patch set uploaded by Awight:
(bug 66141) Allow replaceSection on an unborn page

https://gerrit.wikimedia.org/r/137511

gerritbot added a comment.Jun 5 2014, 2:23 PM

Change 137641 had a related patch set uploaded by Anomie:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137641

Anomie added a comment.Jun 5 2014, 2:24 PM

While I83cdd4ad appears to have made the issue occur more often, the bug is still present before that change if you supply a section parameter when editing the nonexistent template.

gerritbot added a comment.Jun 5 2014, 2:40 PM

Change 137641 merged by jenkins-bot:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137641

gerritbot added a comment.Jun 5 2014, 2:48 PM

Change 137652 had a related patch set uploaded by Anomie:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137652

gerritbot added a comment.Jun 5 2014, 2:48 PM

Change 137652 merged by jenkins-bot:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137652

gerritbot added a comment.Jun 5 2014, 2:51 PM

Change 137653 had a related patch set uploaded by Anomie:
Update TemplateSandbox for bug 66141

https://gerrit.wikimedia.org/r/137653

Anomie added a comment.Jun 5 2014, 2:55 PM

Fixed in TemplateSandbox, and will be included in 1.24wmf8.

That's not to say Awight's patch isn't necessary (I haven't looked closely), but not needed for this bug.

gerritbot added a comment.Jun 5 2014, 3:16 PM

Change 137653 merged by Reedy:
Update TemplateSandbox for bug 66141

https://gerrit.wikimedia.org/r/137653

gerritbot added a comment.Jun 5 2014, 8:31 PM

Change 137511 had a related patch set uploaded by TheDJ:
WikiPage: Allow replaceSection on an nonexistent page

https://gerrit.wikimedia.org/r/137511

gerritbot added a comment.Jun 5 2014, 9:02 PM

Change 137511 merged by jenkins-bot:
WikiPage: Allow replaceSection on an nonexistent page

https://gerrit.wikimedia.org/r/137511

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL