Page MenuHomePhabricator

VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page
Closed, ResolvedPublic

Description

I have been getting this issue since this morning, I think this has something to do with changing image size when the size of an image gets adjusted or changed.
I do not have the exact steps to reproduce for now.But it happened this one time when I changed the thumbnail left aligned image to centre float.

This is the page where you will see the image on which I made the change and getting the edit conflict error :
http://en.wikipedia.beta.wmflabs.org/wiki/9thjunechrome?veaction=edit

We had encountered similar kind of issue quiet a while ago, which was fixed:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

I am not sure, if the same cause is behind the bug or not


Version: unspecified
Severity: normal

Details

Reference
bz66396

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:13 AM
bzimport set Reference to bz66396.

There is a very weird issue, probably introduced by Ed's extension nodes rewrite. Any extension node's children get duplicated on the way back to Parsoid: a hieroglyphs <table> gets two <tbody>s, a gallery <ul> contains all of its <li>s twice, etc.

Change 138521 had a related patch set uploaded by Catrope:
Followup bd49f97: prevent MWExtensionNodes from having children

https://gerrit.wikimedia.org/r/138521

Change 138521 merged by jenkins-bot:
Followup bd49f97: prevent MWExtensionNodes from having children

https://gerrit.wikimedia.org/r/138521

Verified the fix in test2 running wmf 9

Verified the fix in production (en.wiki)