Page MenuHomePhabricator
Create Task
Maniphest T68490

Upload icon appears after anonymous edit save
Closed, ResolvedPublic
Actions

Description

After Change https://gerrit.wikimedia.org/r/#/c/137462/ the upload icon does not appear, if no action is available.

If you edit a page in alpha mode as anonymous (wgMFAnonymousEditing or a maybe change from this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=59937#c15) and save an edit, the site is loading with javascript and the upload button is shown (disabled but visible). To be consistent, it's better to hide the upload button there, too :)

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62598

Details

Reference
bz66490

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:19 AM
• bzimport added a project: MobileFrontend-alpha.
• bzimport set Reference to bz66490.
• bzimport added a subscriber: Unknown Object (MLST).
Florian created this task.Jun 11 2014, 6:08 PM
• bzimport added a comment.Jun 11 2014, 6:10 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Pe5yHhES

Jdlrobson added a comment.Jun 11 2014, 6:16 PM

The patch you mention hasn't been merged yet. I'm not 100% sure what the problem here is. When I check out the page, enable anonymous editing, I edit the page which needs no image, I still do not see the upload icon after the save is complete.

If there is a problem with the above patch could you please comment on that patchset?

Could you elaborate on the bug here - it's not clear to me at all. Screenshots/video might help.

Florian added a comment.Jun 11 2014, 6:38 PM

Ah, sorry, my fault. I mean this change:
https://gerrit.wikimedia.org/r/#/c/137461/

In attachment is a little video :) Main problem is that the edit button is deactivated, too. That i have seen in my change here:
https://gerrit.wikimedia.org/r/#/c/138802/

Florian added a comment.Jun 11 2014, 6:38 PM

Created attachment 15629
Screencapture

Attached:

ScreenCapture_11.06.2014_20.32.32.wmv427 KBDownload

Jdlrobson added a comment.Jun 11 2014, 7:14 PM

Okay. It looks like https://gerrit.wikimedia.org/r/#/c/137462/ fixes this though.

Jdlrobson added a comment.Jun 11 2014, 7:15 PM

See Id10804beae1948942b1a4f62898904b7baf839a2 which hides this whenever it is not available.

Florian added a comment.Jun 13 2014, 10:49 AM

Is merged, and my test success, so will mark as fixed. Can be reopened, if necesary :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL