Page MenuHomePhabricator
Create Task
Maniphest T68494

VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield
Closed, ResolvedPublic
Actions

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Insert another image inside the caption of it.
4.Select the image and observe the position of the context menu that appears on top of the image

Observed Result:
The context menu's position is shifted few pixels to the right.
See the screenshot to compare the position of it .

Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-06-11_at_12.24.46_PM.png (591×1 px, 259 KB)

Details

Reference
bz66494

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:20 AM
• bzimport added projects: VE-deploy-2014-07-03, VisualEditor-ContentEditable.
• bzimport set Reference to bz66494.
Ryasmeen created this task.Jun 11 2014, 7:30 PM
Esanders added a comment.Jun 25 2014, 3:24 PM

WFM in beta labs

Jdforrester-WMF added a comment.Jun 25 2014, 4:18 PM

Created attachment 15743
Demonstration in Beta Labs

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&oldid=108546&veaction=edit

Attached:

Screen_Shot_2014-06-25_at_09.17.12.png (751×1 px, 131 KB)

Jdforrester-WMF added a comment.Jun 25 2014, 4:18 PM

But not for me (though the highlight is correctly aligned now).

gerritbot added a comment.Jun 28 2014, 12:59 PM

Change 142797 had a related patch set uploaded by Esanders:
Add a ve direction class to all surfaces

https://gerrit.wikimedia.org/r/142797

gerritbot added a comment.Jun 28 2014, 9:20 PM

Change 142797 merged by jenkins-bot:
Add a ve direction class to all surfaces

https://gerrit.wikimedia.org/r/142797

Ryasmeen added a comment.Jul 7 2014, 10:10 PM

Verified the fix in Betalabs and test2

Ryasmeen added a comment.Jul 10 2014, 9:26 PM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:00 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL