Page MenuHomePhabricator

data-sort-type should correlate the currencies of data-sort-value cells with 'currency criterion' compatible cells when used sparcely
Closed, DeclinedPublic

Description

Author: mattmill30

Description:
When sorting a column which contains currency values:
Cells with both 'currency criterion' incompatible values and data-sort-value specified with a 'currency criterion' compatible symbol are not included in the comparative ordering of 'currency criterion' compatible values.

E.g.
{| class="wikitable sortable"

+ Comparison of keyboards, segmented by purpose
-

! Manufacturer class="unsortable" | Model data-sort-type="currency" | Price

-

! class="collapsible collapsed" colspan=12 | Wireless

-
AmketteWi-Key Touchdata-sort-value="$42"INR₹2495 ($42)
-
RapooE2700£39.99 ($68)
-
iballMystic BT06data-sort-value="$33"INR₹1,999 ($33)
-
}

What happens when Price column is sorted:
{| class="wikitable sortable"

+ Comparison of keyboards, segmented by purpose
-

! Manufacturer class="unsortable" | Model data-sort-type="currency" | Price

-

! class="collapsible collapsed" colspan=12 | Wireless

-
iballMystic BT06data-sort-value="$33"INR₹1,999 ($33)
-
RapooE2700£39.99 ($68)
-
AmketteWi-Key Touchdata-sort-value="$42"INR₹2495 ($42)
-
}

What should happen:

Keyboards

{| class="wikitable sortable"

+ Comparison of keyboards, segmented by purpose
-

! Manufacturer class="unsortable" | Model data-sort-type="currency" | Price

-

! class="collapsible collapsed" colspan=12 | Wireless

-
iballMystic BT06data-sort-value="$33"INR₹1,999 ($33)
-
AmketteWi-Key Touchdata-sort-value="$42"INR₹2495 ($42)
-
RapooE2700£39.99 ($68)
-
}

Version: 1.24rc
Severity: enhancement

Details

Reference
bz66647

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:13 AM
bzimport set Reference to bz66647.
bzimport added a subscriber: Unknown Object (MLST).

Workaround: Put first what's currently in the brackets.

mattmill30 wrote:

To maintain the difference between backend functionality and UX, use of data-sort-value on each cell of the column with a standardized currency is a workaround.

I don't see why it would do that. 'garbage in, garbage out' principle of keeping data applies here in my opinion. If you leave the program guessing, it is undoubtedly going to guess wrong in certain cases.

Using data-sort-value consistently is what I think is the appropriate approach here.

TheDJ claimed this task.

wont fix it is.