Page MenuHomePhabricator

mwxml2sql fails for `mediawiki' versions above 1.21; patch posted for review
Closed, ResolvedPublic

Description

0) Summary

mwxml2sql' checks the mediawiki' version, and aborts if out of the range 1.5 through 1.21. This is a show-stopper.

I posted a patch for your review. I should extend the upper bound to version 1.24.

  1. Version

(shell)$ mwxml2sql --version
mwxml2sql 0.0.2
Supported input schema versions: 0.4 through 0.8.
Supported output MediaWiki versions: 1.5 through 1.21.

  1. Patch

https://gerrit.wikimedia.org/r/#/c/139413/

Sincerely Yours,
Kent


Version: unspecified
Severity: blocker
OS: Linux
Platform: PC

Details

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:14 AM
bzimport set Reference to bz66663.

wp mirror: Thanks for the patch. If you fix the commit message in Gerrit (see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ) to mention "Bug: 66663" there will be automatic notifications on this bug report.

Change 139413 had a related patch set uploaded by Wpmirrordev:
Extend maximum allowed mediawiki version to 1.24 (Bug: 66663)

https://gerrit.wikimedia.org/r/139413

Change 139413 had a related patch set uploaded by Qgil:
Extend maximum allowed mediawiki version to 1.24

https://gerrit.wikimedia.org/r/139413

(In reply to Andre Klapper from comment #1)

wp mirror: Thanks for the patch. If you fix the commit message in Gerrit
(see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ) to
mention "Bug: 66663" there will be automatic notifications on this bug
report.

Ah, I just came to say this. :)

Ariel: Any chance to review the 20 lines patch in Gerrit?

Ariel: Any chance to review the 20 lines patch in Gerrit?

Dear Sirs,

  1. Database Schema

Currently, MW 1.25 is being deployed. Can someone tell me if the database schema for MW 1.26+ is known at this time? If so, where is the information posted?

If possible, I would like to get ahead of the curve. Otherwise, we file bug reports every six months.

  1. XML Dump format

I understand that the XML dump format will soon be updated to version 0.10. See
https://bugzilla.wikimedia.org/show_bug.cgi?id=72417 and
https://gerrit.wikimedia.org/r/#/c/168583/.

This will also impact `mwxml2sql' which currently supports versions 0.4 through 0.8.

Sincerely Yours,
Kent

(In reply to wp mirror from comment #7)

Dear Sirs,

  1. Database Schema

Currently, MW 1.25 is being deployed. Can someone tell me if the database
schema for MW 1.26+ is known at this time? If so, where is the information
posted?

If possible, I would like to get ahead of the curve. Otherwise, we file bug
reports every six months.

https://github.com/wikimedia/mediawiki/blob/master/maintenance/tables.sql

It won't be final until it's branched...

  • Bug 72886 has been marked as a duplicate of this bug. ***

0.10 is merged now, and will be going live on Wikimedia sites as of Wednesday

Dear Sam,

XML dump files are still being generated using schema 0.9.

  1. Need XML dump using schema 0.10

Do you know when (or where) I can have an XML dump file using schema 0.10? I would like to patch `mwxml2sql' right away; but I need an XML data dump file using schema 0.10 in order to test the patch before posting it to gerrit for review.

  1. Patch ready for schema 0.9

I have ready a patch that brings `mwxml2sql' up to schema 0.9. I am using for production in-house. Should I post it now, or should I wait until I can bring it up to schema 0.10?

  1. Usage of `mwxml2sql'

The previous question is motivated by a growing apprehension that I may be the only person using mwxml2sql'. Is there any way (e.g. analytics) to determine the usage of mwxml2sql'? Would you know if anyone is in a position to say which dump import utilities are best supported and most widely used?

Sincerely Yours,
Kent

https://www.mediawiki.org/wiki/Special:Export/Main_page will give you something in the 0.10 format

That is the point of the XSD files - So you know what format it will be :)

Change 171976 had a related patch set uploaded by Wpmirrordev:
Extend maximum allowed mediawiki version to 1.24

https://gerrit.wikimedia.org/r/171976

Dear Sam,

  1. Patch for schema 0.10

I just submitted https://gerrit.wikimedia.org/r/171976. It actually squashes two patches together (one old, one new). `mwxml2sql' can now handle mediawiki version up to 1.24 (old patch), and XML data dump schemas up to 0.10 (new patch).

  1. Usage of `mwxml2sql'

I still would like to know if anyone else is using `mwxml2sql'. Is there any way to determine this?

Sincerely Yours,
Kent

Nemo_bis lowered the priority of this task from Medium to Low.Apr 9 2015, 7:19 AM
Nemo_bis set Security to None.

Change 171976 had a related patch set uploaded (by Paladox):
Extend maximum allowed mediawiki version to 1.24

https://gerrit.wikimedia.org/r/171976

Change 113103 had a related patch set uploaded (by John Vandenberg):
Support MediaWiki version 1.23

https://gerrit.wikimedia.org/r/113103

See https://gerrit.wikimedia.org/r/#/c/347625/ which should address these issues. Note that shortly these utilities will move to their own repo (TBA once it's available) and removed from the dumps ariel branch.

Change 113103 abandoned by ArielGlenn:
Support MediaWiki version 1.23

Reason:
This change was incorporated in https://gerrit.wikimedia.org/r/#/c/347625/ Thanks! future changes should be against the new repo for these tools, https://gerrit.wikimedia.org/r/operations/dumps/import-tools

https://gerrit.wikimedia.org/r/113103

Ah yes I suppose so. Thanks!