Page MenuHomePhabricator
Create Task
Maniphest T68731

ConfirmAccount: Multiple emails per form submission (token expiry failing?) in 1.19
Closed, ResolvedPublic
Actions

Description

http://wiki.mozilla.org/ just set up ConfirmAccount, and it works great, but sometimes the are are multiple identical emails about an account request. We speculate that it is the result of a token not being expired.

Version: REL1_19-branch
Severity: normal

Details

Reference
bz66731
SubjectRepoBranchLines +/-
Fix RequestAccountPage::confirmEmailToken()mediawiki/extensions/ConfirmAccountREL1_19+9 -9
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:18 AM
• bzimport added a project: MediaWiki-extensions-ConfirmAccount.
• bzimport set Reference to bz66731.
• bzimport added a subscriber: Unknown Object (MLST).
MarkAHershberger created this task.Jun 17 2014, 5:12 PM
Aklapper triaged this task as Low priority.Dec 29 2014, 12:31 AM
Aklapper subscribed.
Paladox subscribed.Apr 24 2015, 7:51 PM

Hi please use Mediawiki 1.23 or 1.24 please. REL1_19 branch hasn't received any fixes for this problem. and may have already been fixed in later versions of mediawiki.

Paladox set Security to None.Apr 24 2015, 7:52 PM
Aklapper renamed this task from ConfirmAccount: Multiple emails per form submission (token expiry failing?) to ConfirmAccount: Multiple emails per form submission (token expiry failing?) in 1.19.Apr 24 2015, 9:41 PM
Paladox added a comment.Apr 24 2015, 10:04 PM

I think this is resolved since Mozilla are using mediawiki 1.23.9.

Aklapper added a comment.Apr 25 2015, 10:28 AM
In T68731#1235325, @Paladox wrote:

I think this is resolved since Mozilla are using mediawiki 1.23.9.

Well, maybe for Mozilla, but maybe not for other users of the REL1_19 branch.

Paladox added a comment.Apr 25 2015, 12:04 PM

Hi I think the fix is not sure though. https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FConfirmAccount.git/3e6302d1628f6ac53bd36779b4fb5dbd575443d1

gerritbot subscribed.Apr 25 2015, 12:37 PM

Change 206513 had a related patch set uploaded (by Paladox):
Fix RequestAccountPage::confirmEmailToken()

https://gerrit.wikimedia.org/r/206513

gerritbot added a project: Patch-For-Review.Apr 25 2015, 12:37 PM
gerritbot added a comment.May 27 2015, 5:02 PM

Change 206513 abandoned by Alex Monk:
Fix RequestAccountPage::confirmEmailToken()

Reason:
branch EOL - https://lists.wikimedia.org/pipermail/mediawiki-announce/2015-May/000177.html

https://gerrit.wikimedia.org/r/206513

Paladox closed this task as Resolved.Jul 8 2015, 7:51 PM
Paladox removed a project: Patch-For-Review.
Paladox removed a subscriber: gerritbot.

MediaWiki support for 1.19 has been discontinued please upgrade to MediaWiki 1.25.

Aklapper added a comment.Jul 9 2015, 1:59 PM
In T68731#1438918, @Paladox wrote:

MediaWiki support for 1.19 has been discontinued please upgrade to MediaWiki 1.25.

No. Users can upgrade to any supported version (e.g. LTS version 1.23), and not only 1.25.

Aklapper added a comment.Jul 9 2015, 2:01 PM

@Paladox: What was exactly resolved in this task via a code change?

Paladox added a comment.Jul 9 2015, 2:10 PM

Hi this https://gerrit.wikimedia.org/r/#/c/206513/ I had a patch waiting for Mediawiki 1.19 but the deadline for the release passed so someone abandoned my patch.

Aklapper added a comment.Jul 9 2015, 2:24 PM

@Paladox: That does not answer my question. Please explain what was resolved, instead of explaining what was not resolved.

Paladox added a comment.Jul 9 2015, 2:33 PM

Well it fixes confirmEmailToken which causes the email to show multiple times in Mozilla firefox.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL