Steps to reproduce:
1.Open a page with VE
2.Insert an image
3.Add caption to it
4.Make it frameless and uncheck the wrap option
Observed Result;
The image moves to the left and loses all its content in the caption
Environment:Test2 and production (en.wiki)
Version: unspecified
Severity: normal
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [WIP] Preserve captions even in inline images | mediawiki/extensions/VisualEditor | master | +102 -89 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T68808 Making an image Frameless with out any wrap option deletes the content of the caption | |||
| Duplicate | None | T75575 Images: Supply the (undisplayed) captions of inline images in the DOM, not just as wikitext | |||
| Resolved | cscott | T50958 Images: parse caption separately all the way to DOM and use DOMFragment encapsulation |
The bit of this where the transaction is not undoable feels like a DM bug. Ed, could you look it it?
Actually, this is the issue of retaining the caption data in inline images that I discussed with Ed and later with Roan yesterday. Roan mentioned the work on sub-documents as a potential fix for that, and perhaps a mid-way solution involving similar work to what the MWReferenceNode is doing.
We need to make sure the caption information is kept to inline images and then also sent back to Parsoid through the data-mw field.
Currently captions on inline images are only made available as wikitext by Parsoid. In order to preserve these when converting between the block & inline that would need to change.
A patch for T50958 on the Parsoid side is imminent, so perhaps it's time to wake up the VE side of this bug.
Change 239300 had a related patch set uploaded (by Alex Monk):
[WIP] Preserve captions even in inline images