Page MenuHomePhabricator

VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS
Closed, ResolvedPublic

Description

Screenshot-1

Steps to reproduce:

1.Open a page with safari in any iOS device which contains image in it
2.Now tap on the image to select it

Observed Result:
The highlight for the image is appearing much below the image

See the screenshots attached


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=65326

Attached:

IMG_0021.jpg (768×1 px, 51 KB)

Details

Reference
bz67063

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:38 AM
bzimport set Reference to bz67063.

Created attachment 15726
Screenshot-2

Attached:

IMG_0019.jpg (768×1 px, 30 KB)

In every browser except iOS7 getClientRects is relative to the viewport. In iOS7 it is relative to document. Thanks Apple.

Want to write up a bug report for Apple?

Change 142260 had a related patch set uploaded by Esanders:
Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260

Change 142260 merged by jenkins-bot:
FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260

The highlight for images appearing in wrong position is now fixed ! :)
However the tapping on link or image redirecting to the link target or image file page and second tap on reference closing the VE is still there.Therefore, I suppose the following bugs are not related:

https://bugzilla.wikimedia.org/show_bug.cgi?id=65326
https://bugzilla.wikimedia.org/show_bug.cgi?id=67002

Verified the fix in production