Page MenuHomePhabricator

In desktop mode, Minerva appends the table of contents to the end of the article
Closed, ResolvedPublic

Description

See:
https://en.wikipedia.org/wiki/Textile_manufacturing?useskin=minerva

Instead of replacing the existing TOC, Minerva appends the JS-generated TOC to the end of the article.


Version: unspecified
Severity: normal

Details

Reference
bz67101

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:40 AM
bzimport set Reference to bz67101.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tofvLiMs

Minerva desktop has no understanding of sections, so the article is one big lead section so this is unfortunate but expected.

This is the one major difference between desktop and mobile that stops it being a valid registered skin.

Seems like it should be able to find the existing TOC and replace it on desktop (rather than finding the end of the first section and appending).

Change 143062 had a related patch set uploaded by Florianschmidtwelzow:
Minerva Desktop: Remove toggling and fix TOC

https://gerrit.wikimedia.org/r/143062

Change 143062 merged by jenkins-bot:
Minerva Desktop: fix TOC

https://gerrit.wikimedia.org/r/143062