Page MenuHomePhabricator

VisualEditor: Typing when a focusable node is selected should do nothing
Closed, ResolvedPublic

Description

Correct outcome:

  • Select an inline image (or a reference or alien or…).
  • Press "a".

Observe that the reference has been deleted, and an 'a' is in its place.

Bad outcome;

  • Select a block image (or block template or…).
  • Press "a".

Observe that the block image has not been deleted, and the 'a' is not in its place (and no transaction has occurred).


Version: unspecified
Severity: normal

Details

Reference
bz67177

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:28 AM
bzimport set Reference to bz67177.

Real world comparison:

  • Open/Libre office: typing while selecting an image does nothing
  • Google docs: typing replaces the image

I think it's a rare workflow where you select a block image and want to replace it with a paragraph, and if you really do you can just press backspace/delete. We have taken other measures to prevent the accidental deletion of focusable nodes elsewhere (e.g. adjacent backspace only selects) so this seems like a logical extension.

Change 146808 had a related patch set uploaded by Esanders:
Prevent deletion of focusable nodes by typing

https://gerrit.wikimedia.org/r/146808

Change 146808 merged by jenkins-bot:
Prevent deletion of focusable nodes by typing

https://gerrit.wikimedia.org/r/146808