Page MenuHomePhabricator

Flow: Hovercards beta feature blanks Hide post/topic dialog titlebar and button text
Open, HighPublic

Description

missing "Hide" in title and button of moderation dialog

Go to http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow logged in.
Click action menu on a topic or post, choose Hide.

The jQuery dialog is missing "Hide" in titlebar and button. It has "Cancel." See attachment.

I reproduced in Firefox and Chrome, with and without ?debug=1. But now it's working in Firefox. If you try ?uselang=qqx there's no string. Works fine on ee-flow.


Version: master
Severity: normal

Attached:

2014-06-27_Flow_hide_post_dialog_bug.png (198×345 px, 3 KB)

Details

Reference
bz67215

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:31 AM
bzimport set Reference to bz67215.
bzimport added a subscriber: Unknown Object (MLST).

Added to current sprint, affecting moderation actions (high-priority area).

https://trello.com/c/jFhn4AsO

This works correctly on Beta now.

Re-opened, as it still seems to be happening on both Beta and Mediawiki (but still works properly at ee-flow).

Works for me. Sounds like a translation/caching problem that has since been fixed...

Turns out Hovercards is blanking out every action link's title attribute on hover, and the moderation dialog uses that title attribute for the titlebar and button text.

I think fixing bug 67226 would fix this, as Flow would be using message keys for text instead of reusing the title of the action menu.