Page MenuHomePhabricator

Extensions missing REL1_23 branches
Closed, ResolvedPublic

Description

When updating Uncyclopedia today I noticed that the StopForumSpam extension didn't have a REL1_23 branch.

Just tried setting up CirrusSearch, and noticed that the Elastica extension doesn't have a REL1_23 branch either.

According to bug 64157 comment 3, Mark created "most" of these branches. Why weren't *all* of them created?


Version: 1.22.3
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64157

Details

Reference
bz67270

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:34 AM
bzimport set Reference to bz67270.

Is there a list of remaining extensions without REL1_23 branches?

I wrote a simple script to query the Github API. Here's the list:

mediawiki-extensions-Diagnosis is missing REL1_23!
mediawiki-extensions-PageCredit is missing REL1_23!
mediawiki-extensions-Parsoid-cpp-contrib-libhubbub is missing REL1_23!
mediawiki-extensions-Parsoid-cpp-contrib-pugixml is missing REL1_23!
mediawiki-extensions-WikiTextLoggedInOut is missing REL1_23!
mediawiki-extensions-GuidedTour-guiders is missing REL1_23!
mediawiki-extensions-JsonData-JsonSchema is missing REL1_23!
mediawiki-extensions-Parsoid-js-contrib is missing REL1_23!
mediawiki-extensions-Wikibase-easyrdf is missing REL1_23!
mediawiki-extensions-CloudSearch is missing REL1_23!
mediawiki-extensions-DataTypes is missing REL1_23!
mediawiki-extensions-ValueView is missing REL1_23!
mediawiki-extensions-CirrusSearch-Elastica is missing REL1_23!
mediawiki-extensions-YetAnotherKeywords is missing REL1_23!
mediawiki-extensions-NumerAlpha is missing REL1_23!
mediawiki-extensions-DataValueImplementations is missing REL1_23!
mediawiki-extensions-DataValuesInterfaces is missing REL1_23!
mediawiki-extensions-Wikidata is missing REL1_23!
mediawiki-extensions-Newsletter is missing REL1_23!
mediawiki-extensions-Minifier is missing REL1_23!
mediawiki-extensions-Elastica is missing REL1_23!
mediawiki-extensions-UserPageViewTracker is missing REL1_23!
mediawiki-extensions-DisqusTag is missing REL1_23!
mediawiki-extensions-PageDisqus is missing REL1_23!
mediawiki-extensions-GoogleDocTag is missing REL1_23!
mediawiki-extensions-CategoryTagSorter is missing REL1_23!
mediawiki-extensions-WikimediaEvents is missing REL1_23!
mediawiki-extensions-HelpPages is missing REL1_23!
mediawiki-extensions-TimeMachine is missing REL1_23!
mediawiki-extensions-VectorBeta is missing REL1_23!
mediawiki-extensions-ContentTranslation is missing REL1_23!
mediawiki-extensions-WikibaseRepo is missing REL1_23!
mediawiki-extensions-WikibaseClient is missing REL1_23!
mediawiki-extensions-WikibaseLib is missing REL1_23!
mediawiki-extensions-SemanticSifter is missing REL1_23!
mediawiki-extensions-CentralNotice-BannerProxy is missing REL1_23!
mediawiki-extensions-TitleIcon is missing REL1_23!
mediawiki-extensions-InterwikiExistence is missing REL1_23!
mediawiki-extensions-SemanticRating is missing REL1_23!
mediawiki-extensions-SemanticFormsDisplayTitle is missing REL1_23!
mediawiki-extensions-SemanticFormsUniqueValue is missing REL1_23!
mediawiki-extensions-PartitionQuery is missing REL1_23!
mediawiki-extensions-ImportBibliography is missing REL1_23!
mediawiki-extensions-IssueTracker is missing REL1_23!
mediawiki-extensions-MailChimpSubscription is missing REL1_23!
mediawiki-extensions-YotpoReviews is missing REL1_23!
mediawiki-extensions-SubpageWatchlist is missing REL1_23!
mediawiki-extensions-MultiUpload is missing REL1_23!
mediawiki-extensions-Capiunto is missing REL1_23!
mediawiki-extensions-GlobalCssJs is missing REL1_23!
mediawiki-extensions-LanguageTag is missing REL1_23!
mediawiki-extensions-MobileApp is missing REL1_23!
mediawiki-extensions-DataValuesCommon is missing REL1_23!
mediawiki-extensions-Isbn is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator-node_modules is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator-bundler is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator-latex_renderer is missing REL1_23!
mediawiki-extensions-PageTools is missing REL1_23!
mediawiki-extensions-PubSubHubbub is missing REL1_23!
mediawiki-extensions-JsonConfig is missing REL1_23!
mediawiki-extensions-GlobalPreferences is missing REL1_23!
mediawiki-extensions-MediaWikiChat is missing REL1_23!
mediawiki-extensions-TextExtracts is missing REL1_23!
mediawiki-extensions-StopForumSpam is missing REL1_23!
mediawiki-extensions-DataValuesJavascript is missing REL1_23!
mediawiki-extensions-PageBlock is missing REL1_23!
mediawiki-extensions-Convert2Wiki is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator-html_renderer is missing REL1_23!
mediawiki-extensions-Collection-OfflineContentGenerator-text_renderer is missing REL1_23!
mediawiki-extensions-GlobalContributions is missing REL1_23!
mediawiki-extensions-FirstSteps is missing REL1_23!
mediawiki-extensions-VideoJsPlayer is missing REL1_23!
mediawiki-extensions-OpenBadges is missing REL1_23!
mediawiki-extensions-Workflow is missing REL1_23!
mediawiki-extensions-Ipernity is missing REL1_23!
mediawiki-extensions-PdfBook is missing REL1_23!
mediawiki-extensions-Tabs is missing REL1_23!
mediawiki-extensions-PropertySuggester is missing REL1_23!
mediawiki-extensions-GoogleTagManager is missing REL1_23!
mediawiki-extensions-PhpTags is missing REL1_23!
mediawiki-extensions-PhpTagsDebugger is missing REL1_23!
mediawiki-extensions-PhpTagsFunctions is missing REL1_23!
mediawiki-extensions-PhpTagsWidgets is missing REL1_23!
mediawiki-extensions-PhpTagsCodeEditor is missing REL1_23!
mediawiki-extensions-PhpTagsWiki is missing REL1_23!
mediawiki-extensions-PhpTagsMaps is missing REL1_23!
mediawiki-extensions-GlobalUserrights is missing REL1_23!
mediawiki-extensions-Popups is missing REL1_23!
mediawiki-extensions-CommonMessages is missing REL1_23!
mediawiki-extensions-NoUnwrap is missing REL1_23!
mediawiki-extensions-FundraisingChart is missing REL1_23!
mediawiki-extensions-ShrinkTheWeb is missing REL1_23!
mediawiki-extensions-SimpleSamlAuth is missing REL1_23!
mediawiki-extensions-SemanticHighcharts is missing REL1_23!
mediawiki-extensions-IframePage is missing REL1_23!
mediawiki-extensions-WikiCortex is missing REL1_23!
mediawiki-extensions-ShortUrlApi is missing REL1_23!
mediawiki-extensions-NukeDPL is missing REL1_23!
mediawiki-extensions-GoogleAppEngine is missing REL1_23!
mediawiki-extensions-PubSubHubbubSubscriber is missing REL1_23!
mediawiki-extensions-Petition is missing REL1_23!
mediawiki-extensions-VisualChat is missing REL1_23!
mediawiki-extensions-Mantle is missing REL1_23!
mediawiki-extensions-AmazonLookup is missing REL1_23!
mediawiki-extensions-MolHandler is missing REL1_23!
mediawiki-extensions-ReorderParserPhases is missing REL1_23!
mediawiki-extensions-ExtraLanguageLink is missing REL1_23!
mediawiki-extensions-SiteSettings is missing REL1_23!
mediawiki-extensions-PerformanceMonitor is missing REL1_23!
mediawiki-extensions-AjaxLogin is missing REL1_23!
mediawiki-extensions-SimpleChanges is missing REL1_23!
mediawiki-extensions-Limn is missing REL1_23!
mediawiki-extensions-SemanticForms is missing REL1_23!
mediawiki-extensions-GlobalUserPage is missing REL1_23!
mediawiki-extensions-ZeroBanner is missing REL1_23!
mediawiki-extensions-ZeroPortal is missing REL1_23!
mediawiki-extensions-IfTemplates is missing REL1_23!
mediawiki-extensions-WebCache is missing REL1_23!
mediawiki-extensions-NamespaceHTML is missing REL1_23!
mediawiki-extensions-ActivityMonitor is missing REL1_23!
mediawiki-extensions-UserGroups is missing REL1_23!
mediawiki-extensions-XMLContentExtension is missing REL1_23!
mediawiki-extensions-UrlShortener is missing REL1_23!
mediawiki-extensions-BounceHandler is missing REL1_23!
mediawiki-extensions-ListSignup is missing REL1_23!
mediawiki-extensions-Vine is missing REL1_23!
mediawiki-extensions-SemanticDummyEditor is missing REL1_23!
mediawiki-extensions-Citoid is missing REL1_23!
mediawiki-extensions-FundraisingTranslateWorkflow is missing REL1_23!
mediawiki-extensions-MixedNamespaceSearchSuggestions is missing REL1_23!
mediawiki-extensions-AddMessages is missing REL1_23!
mediawiki-extensions-GoogleLogin is missing REL1_23!
mediawiki-extensions-SwiftMailer is missing REL1_23!

A few of these are empty repositories, so that's fine. Some of the ones at the very end were created after the 1.23 branchpoint, so those are fine too. A bunch in the middle (the majority) aren't though. I think this has something to do with when the repositories were created.

<off-topic>I hope the new release management team plans on fixing this mess!</off-topic>

(In reply to Kunal Mehta (Legoktm) from comment #2)

<off-topic>I hope the new release management team plans on fixing this
mess!</off-topic>

I don't think this is off topic at all. The problem needs to be fixed and the Release Management team are the people to do it.

I really don't understand why this discussion didn't happen on Bug #64157, though.

  • This bug has been marked as a duplicate of bug 64157 ***

How is this a duplicate? Bug 64157 is about branches pointing to the wrong place, this about branches *not existing*.

Thanks for pointing that difference out. I missed it. They're symptoms of the same problem. Fixing both at the same time right now.

I'm not so sure they're "symptoms of the same problem" any more. But I think I've fixed these. Leaving open so you can tell me if I'm wrong.

Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.

But in some cases it's a commit behind apparently like UrlShortener and GlobalPreferences.

You also didn't update the REL1_23 branch of the meta mediawiki-extensions repo.

(In reply to Kunal Mehta (Legoktm) from comment #8)

Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.

I don't think this is worse. This is better.

The extensions that didn't have REL1_23 branches have REL1_23 branches now. It isn't likely that any changes have been made to the extensions that are not compatible with 1.23 at this point. If there are any such problems, then that is a new bug.

In any case development can continue on master without affecting the REL1_23 branch.

You also didn't update the REL1_23 branch of the meta mediawiki-extensions
repo.

Fixing. Once that is done, I think this bug can be closed. It is important to note that the REL1_23 branch of mediawiki-extensions is new with 1.23.

(In reply to Mark A. Hershberger from comment #10)

(In reply to Kunal Mehta (Legoktm) from comment #8)

Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.

I don't think this is worse. This is better.

The extensions that didn't have REL1_23 branches have REL1_23 branches now.
It isn't likely that any changes have been made to the extensions that are
not compatible with 1.23 at this point. If there are any such problems,
then that is a new bug.

Just so I have this clear: this means that there are (potentially) commits in the extensions listed in comment 2 that were made post 1.23's release and thus might have (correctly) assumed they can make non-1.23-compatible changes? Is there a reason we didn't make the REL1_23 branch for these remaining extensions at the same point in time as the 1.23 release?

(In reply to Mark A. Hershberger from comment #10)

(In reply to Kunal Mehta (Legoktm) from comment #8)

Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.

I don't think this is worse. This is better.

How is this better in any way? People are going to see "Download 1.23" and assume it works. At least before people would ask on the talk page and I could give them the proper commit to use (https://www.mediawiki.org/wiki/Extension_talk:CirrusSearch#which_version_of_mediawiki_cirrusserch.2C_elastica.2Celasticsearch_working_together_well.3F_44870).

I know of at least two extensions where master is incompatible with REL1_23, and there are probably more, and now the REL1_23 branch isn't compatible with MW1.23.

The extensions that didn't have REL1_23 branches have REL1_23 branches now.
It isn't likely that any changes have been made to the extensions that are
not compatible with 1.23 at this point. If there are any such problems,
then that is a new bug.

No it's not a new bug. Before I filed the bug it was missing. People will come on IRC (I helped at least 3 people with this), so we can point them in the right direction. Now it's just downright misleading and we have to tell people "don't use the branch that we say is compatible with 1.23, it's actually not compatible, use this instead".

In any case development can continue on master without affecting the REL1_23
branch.

Yes, we do that regardless.

You also didn't update the REL1_23 branch of the meta mediawiki-extensions
repo.

Fixing. Once that is done, I think this bug can be closed. It is
important to note that the REL1_23 branch of mediawiki-extensions is new
with 1.23.

Thanks. Just remember to re-update it when you fix where the REL1_23 branches to point to the right place.

(In reply to Greg Grossmeier from comment #11)

Just so I have this clear: this means that there are (potentially) commits
in the extensions listed in comment 2 that were made post 1.23's release and
thus might have (correctly) assumed they can make non-1.23-compatible
changes? Is there a reason we didn't make the REL1_23 branch for these
remaining extensions at the same point in time as the 1.23 release?

Not just potentially, yes there are extensions that did that (I know because I did that to one of mine). Mark or Markus will have to answer the second part, I don't know why they didn't do that either.

Just so I have this clear: this means that there are (potentially) commits
in the extensions listed in comment 2 that were made post 1.23's release and
thus might have (correctly) assumed they can make non-1.23-compatible
changes? Is there a reason we didn't make the REL1_23 branch for these
remaining extensions at the same point in time as the 1.23 release?

Why not just use the existing script [1] which has support (If I'm reading it correctly) for branching extensions based on the timestamp of when core branched?

[1] https://git.wikimedia.org/blob/mediawiki%2Ftools%2Frelease.git/master/make-extension-branches%2Fmake-extension-branches

(In reply to Greg Grossmeier from comment #11)

Is there a reason we didn't make the REL1_23 branch for these
remaining extensions at the same point in time as the 1.23 release?

I thought I did. In fact, I specifically recall running the script Brian mentions. Still, the history in Gerrit shows I didn't run the script. Or, rather, the problems in Bug #64157 show that branching was done with the wrong date.

Unfortunately, gerrit/git won't let me delete the bad branches. The easiest thing to do would be to drop those REL1_23 branches that don't have their own commits and recreate them.

(In reply to Bawolff (Brian Wolff) from comment #14)

Why not just use the existing script [1] which has support (If I'm reading
it correctly) for branching extensions based on the timestamp of when core
branched?

That script requires a configuration file that isn't documented. I have a shell script that does the same thing that doesn't require an un-documented configuration file.

However a bug in my invocation of the script that caused the problem. I gave it a quoted date string after verifying that git could use those. Unfortunately, I didn't take into account the problem of shell quoting when that script calls another one.

This is ridiculous. I'm just going to fix it myself.

(In reply to Kunal Mehta (Legoktm) from comment #16)

This is ridiculous. I'm just going to fix it myself.

Thanks! Let me know if you need any gerrit approvals.

Unfortunately, gerrit/git won't let me delete the bad branches. The easiest
thing to do would be to drop those REL1_23 branches that don't have their
own commits and recreate them.

I believe you need direct push rights to do that. Chad is the only one with such rights on our repo afaik.

(In reply to Bawolff (Brian Wolff) from comment #18)

Unfortunately, gerrit/git won't let me delete the bad branches. The easiest
thing to do would be to drop those REL1_23 branches that don't have their
own commits and recreate them.

I believe you need direct push rights to do that. Chad is the only one with
such rights on our repo afaik.

It's been pointed out to me that this is incorrect, and you can delete branches from the gerrit interface. People with +2 on core have permissions to delete most branches in extensions (but not on core).

(In reply to Bawolff (Brian Wolff) from comment #19)

It's been pointed out to me that this is incorrect, and you can delete
branches from the gerrit interface. People with +2 on core have permissions
to delete most branches in extensions (but not on core).

Hrm... the gerrit interface. That would be why this didn't work:

$ git push origin --delete REL1_23
remote: Branch refs/heads/REL1_23:
remote: You need 'Push' rights with the 'Force Push'
remote: flag set to delete references.
remote: User: mah
remote: Please read the documentation and contact an administrator
remote: if you feel the configuration is incorrect
remote: Processing changes: refs: 1, done
To ssh://mah@gerrit.wikimedia.org:29418/mediawiki/extensions/UrlShortener.git
! [remote rejected] REL1_23 (cannot delete references)
error: failed to push some refs to 'ssh://mah@gerrit.wikimedia.org:29418/mediawiki/extensions/UrlShortener.git'

Note that after deleting this in gerrit you have to (at least, I had to) completely delete the git directory and check out a fresh copy for the change to show up.

(In reply to Mark A. Hershberger from comment #20)

Hrm... the gerrit interface. That would be why this didn't work:

$ git push origin --delete REL1_23

Did you try: $ git push origin :REL1_23

(In reply to Mark A. Hershberger from comment #21)

Note that after deleting this in gerrit you have to (at least, I had to)
completely delete the git directory and check out a fresh copy for the
change to show up.

That's because remote branches are different from local branches.

...

Okay, I finished. Took me an hour not including a quick snack break.

Here's what I did. Using the list I posted in comment 2, I manually looked at each one, and found where the branch point should have been, and updated it in gerrit.


mediawiki-extensions-Diagnosis is missing REL1_23! - fp
mediawiki-extensions-PageCredit is missing REL1_23! - fp
mediawiki-extensions-Parsoid-cpp-contrib-libhubbub is missing REL1_23! - created
mediawiki-extensions-Parsoid-cpp-contrib-pugixml is missing REL1_23! - created
mediawiki-extensions-GuidedTour-guiders is missing REL1_23! - created
mediawiki-extensions-JsonData-JsonSchema is missing REL1_23! - created
mediawiki-extensions-Parsoid-js-contrib is missing REL1_23! - created
mediawiki-extensions-Wikibase-easyrdf is missing REL1_23! - created
mediawiki-extensions-CloudSearch is missing REL1_23! - empty
mediawiki-extensions-DataTypes is missing REL1_23! - some error
mediawiki-extensions-ValueView is missing REL1_23! - some error
mediawiki-extensions-CirrusSearch-Elastica is missing REL1_23! - created
mediawiki-extensions-Wikidata is missing REL1_23! - created
mediawiki-extensions-Elastica is missing REL1_23! - fixed
mediawiki-extensions-WikimediaEvents is missing REL1_23! - fixed
mediawiki-extensions-HelpPages is missing REL1_23! - fixed
mediawiki-extensions-VectorBeta is missing REL1_23! - fixed
mediawiki-extensions-ContentTranslation is missing REL1_23! - fixed
mediawiki-extensions-SemanticSifter is missing REL1_23! - fixed
mediawiki-extensions-TitleIcon is missing REL1_23! - fixed
mediawiki-extensions-SemanticRating is missing REL1_23! - fixed
mediawiki-extensions-YotpoReviews is missing REL1_23! - fixed
mediawiki-extensions-Capiunto is missing REL1_23! - fixed
mediawiki-extensions-GlobalCssJs is missing REL1_23! - fixed
mediawiki-extensions-LanguageTag is missing REL1_23! - fixed
mediawiki-extensions-MobileApp is missing REL1_23! - fixed
mediawiki-extensions-Collection-OfflineContentGenerator is missing REL1_23! - created
mediawiki-extensions-Collection-OfflineContentGenerator-node_modules is missing REL1_23! - created
mediawiki-extensions-Collection-OfflineContentGenerator-bundler is missing REL1_23! - created
mediawiki-extensions-Collection-OfflineContentGenerator-latex_renderer is missing REL1_23! - created
mediawiki-extensions-PageTools is missing REL1_23! - fixed
mediawiki-extensions-PubSubHubbub is missing REL1_23! - fixed
mediawiki-extensions-JsonConfig is missing REL1_23! - fixed
mediawiki-extensions-GlobalPreferences is missing REL1_23! - fixed
mediawiki-extensions-MediaWikiChat is missing REL1_23! - fixed
mediawiki-extensions-TextExtracts is missing REL1_23! - fixed
mediawiki-extensions-StopForumSpam is missing REL1_23! - fixed
mediawiki-extensions-Convert2Wiki is missing REL1_23! - fixed
mediawiki-extensions-Collection-OfflineContentGenerator-text_renderer is missing REL1_23! - created
mediawiki-extensions-GlobalContributions is missing REL1_23! - fixed
mediawiki-extensions-FirstSteps is missing REL1_23! - fixed
mediawiki-extensions-PdfBook is missing REL1_23! - fixed
mediawiki-extensions-Tabs is missing REL1_23! - created
mediawiki-extensions-PhpTags is missing REL1_23! - fixed
mediawiki-extensions-PhpTagsFunctions is missing REL1_23! - fixed
mediawiki-extensions-GlobalUserrights is missing REL1_23! - fixed
mediawiki-extensions-Popups is missing REL1_23! - fixed
mediawiki-extensions-CommonMessages is missing REL1_23! - deleted
mediawiki-extensions-FundraisingChart is missing REL1_23! - fixed
mediawiki-extensions-IframePage is missing REL1_23! - deleted
mediawiki-extensions-NukeDPL is missing REL1_23! - deleted
mediawiki-extensions-GoogleAppEngine is missing REL1_23! - deleted
mediawiki-extensions-PubSubHubbubSubscriber is missing REL1_23! - deleted
mediawiki-extensions-Petition is missing REL1_23! - deleted
mediawiki-extensions-VisualChat is missing REL1_23! - dleeted
mediawiki-extensions-Mantle is missing REL1_23! - deleted
mediawiki-extensions-AmazonLookup is missing REL1_23! - deleted
mediawiki-extensions-MolHandler is missing REL1_23! - deleted
mediawiki-extensions-ReorderParserPhases is missing REL1_23! - deleted
mediawiki-extensions-ExtraLanguageLink is missing REL1_23! - deleted
mediawiki-extensions-SiteSettings is missing REL1_23! - deleted
mediawiki-extensions-PerformanceMonitor is missing REL1_23! - deleted
mediawiki-extensions-AjaxLogin is missing REL1_23! - Imported from SVN, so I left this alone
mediawiki-extensions-SimpleChanges is missing REL1_23! - deleted
mediawiki-extensions-Limn is missing REL1_23! - didn't exist
mediawiki-extensions-SemanticForms is missing REL1_23! - something fishy is going on here...REL1_23 isn't replicated to github.
mediawiki-extensions-GlobalUserPage is missing REL1_23! - deleted
mediawiki-extensions-ZeroBanner is missing REL1_23! - fixed
mediawiki-extensions-ZeroPortal is missing REL1_23! - fixed
mediawiki-extensions-IfTemplates is missing REL1_23! - deleted
mediawiki-extensions-WebCache is missing REL1_23! - deleted
mediawiki-extensions-NamespaceHTML is missing REL1_23! - deleted
mediawiki-extensions-ActivityMonitor is missing REL1_23! - deleted
mediawiki-extensions-UserGroups is missing REL1_23! - deleted
mediawiki-extensions-XMLContentExtension is missing REL1_23! - deleted
mediawiki-extensions-UrlShortener is missing REL1_23! - I think Mark did this one?
mediawiki-extensions-BounceHandler is missing REL1_23! - deleted
mediawiki-extensions-ListSignup is missing REL1_23! - I think the author has created a REL1_22 branch, so I didn't touch this
mediawiki-extensions-Vine is missing REL1_23! - deleted
mediawiki-extensions-SemanticDummyEditor is missing REL1_23! - deleted
mediawiki-extensions-Citoid is missing REL1_23! - deleted
mediawiki-extensions-FundraisingTranslateWorkflow is missing REL1_23! - deleted
mediawiki-extensions-MixedNamespaceSearchSuggestions is missing REL1_23! - deleted
mediawiki-extensions-AddMessages is missing REL1_23! - deleted
mediawiki-extensions-GoogleLogin is missing REL1_23! - deleted

mediawiki-extensions-SwiftMailer is missing REL1_23! - deleted

Comment key:

  • fp = False positive in my script
  • created = No REL1_23 branch existed, so I created one.
  • fixed = REL1_23 branch was pointing at the wrong place and I fixed it
  • deleted = Extension was created after REL1_23 branch point, and shouldn't have a REL1_23 branch.

Only Elastica updated the -extensions metarepo. Fixing that right now...

Change 144055 had a related patch set uploaded by Legoktm:
Sync with updated REL1_23 branches in extensions

https://gerrit.wikimedia.org/r/144055

Change 144055 abandoned by Legoktm:
Sync with updated REL1_23 branches in extensions

Reason:
Erk, wrong branch.

https://gerrit.wikimedia.org/r/144055

Change 144056 had a related patch set uploaded by Legoktm:
Sync with updated REL1_23 branches in extensions

https://gerrit.wikimedia.org/r/144056

Change 144056 merged by Legoktm:
Sync with updated REL1_23 branches in extensions

https://gerrit.wikimedia.org/r/144056

Cool trick I learned from MatmaRex:

$ git submodule foreach "git checkout REL1_23 || :"

(In reply to Kunal Mehta (Legoktm) from comment #22)

(In reply to Mark A. Hershberger from comment #20)

Hrm... the gerrit interface. That would be why this didn't work:

$ git push origin --delete REL1_23

Did you try: $ git push origin :REL1_23

That is the older syntax. From git 1.7.0 notes:

https://github.com/gitster/git/blob/master/Documentation/RelNotes/1.7.0.txt#L154

  • "git push" learned "git push origin --delete branch", a syntactic sugar for "git push origin :branch".

Kunal,

Thanks for getting this done. I was busy with other work and traveling till now and just sat down to take care of this now in case you hadn't had time.

I appreciate your help.

Was just checking a fresh checkout of the extensions directory and it looks like you didn't actually branch PhpTags (set branch to Ib6e62863d6ec34e7ec696fe203d9fcf99abbbbd7), or PhpTagsFunctions (I63093589614dd7406c70a3225ac012245efefbd9).

ValueView wasn't actually deleted from the REL1_23 checkout of extensions but was not tagged. Same with IframePage.

It looked like IframePage was simple enough to be tagged REL1_23, but it also looked like it was missing a file or two. Emailed the author.

Change 144269 had a related patch set uploaded by MarkAHershberger:
remove IframePage, ValueView

https://gerrit.wikimedia.org/r/144269

Change 144269 abandoned by MarkAHershberger:
remove IframePage, ValueView

Reason:
Wrong branch

https://gerrit.wikimedia.org/r/144269

Change 144270 had a related patch set uploaded by Brian Wolff:
Set REL1_23 branch for .gitreview.

https://gerrit.wikimedia.org/r/144270

Change 144270 merged by Legoktm:
Set REL1_23 branch for .gitreview.

https://gerrit.wikimedia.org/r/144270

Change 144271 had a related patch set uploaded by Legoktm:
Remove IframePage and ValueView

https://gerrit.wikimedia.org/r/144271

Is this resolved now? The above patches are merged and I think all the issues mentioned in the comments are addressed, no?

(In reply to Greg Grossmeier from comment #37)

Is this resolved now? The above patches are merged and I think all the
issues mentioned in the comments are addressed, no?

Yes. Mark's unmerged patch is tangential but not specifically related to this bug.

Thanks everybody for your work on fixing this!