Page MenuHomePhabricator

edit conflict raises PageNotSaved exception instead of EditConflict
Closed, ResolvedPublic

Description

>>> Benutzer Diskussion:Bernd Schwabe in Hannover <<<
+
+ {{ers:user:xqbot/LD-Hinweis|Harald Härke|angelegte}}

Comment: Bot: Benachrichtigung über Löschdiskussion zum Artikel [[Harald Härke]]

Traceback (most recent call last):
  File "C:\pwb\core\pwb.py", line 153, in <module>
    run_python_file(fn, argv, argvu)
  File "C:\pwb\core\pwb.py", line 67, in run_python_file
    exec(compile(source, filename, "exec"), main_mod.__dict__)
  File "C:\pwb\core\scripts\la.py", line 273, in <module>
    main()
  File "C:\pwb\core\scripts\la.py", line 265, in main
    bot.run()
  File "C:\pwb\core\scripts\la.py", line 96, in run
    self.treat(article)
  File "C:\pwb\core\scripts\la.py", line 156, in treat
    self.inform(user, page=page.title(), action=u'angelegte')
  File "C:\pwb\core\scripts\la.py", line 194, in inform
    if not self.save(text, talk, self.summary % param, minorEdit=False):
  File "C:\pwb\core\scripts\la.py", line 238, in save
    minorEdit=minorEdit, botflag=botflag)
  File "C:\pwb\core\pywikibot\page.py", line 964, in put
    **kwargs)
  File "C:\pwb\core\pywikibot\__init__.py", line 423, in wrapper
    return method(*__args, **__kw)
  File "C:\pwb\core\pywikibot\page.py", line 885, in save
    **kwargs)
  File "C:\pwb\core\pywikibot\page.py", line 911, in _save
    raise pywikibot.PageNotSaved("%s: %s" % (link, err))
pywikibot.exceptions.PageNotSaved: [[Benutzer Diskussion:Bernd Schwabe in Hannover]]: editpage: Edit conflict detected; saving aborted.
<class 'pywikibot.exceptions.PageNotSaved'>
CRITICAL: Waiting for 1 network thread(s) to finish. Press ctrl-c to abort

The Problem is that try: ... except pywikibot.EditConflict does not hints the exceptions but it should do.


Version: core-(2.0)
Severity: normal

Details

Reference
bz67276

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport set Reference to bz67276.
bzimport added a subscriber: Unknown Object (????).

Change 142901 had a related patch set uploaded by Xqt:
(bug 67276) do not pass exceptions silently

https://gerrit.wikimedia.org/r/142901

Change 142901 abandoned by Xqt:
(bug 67276) do not pass exceptions silently

https://gerrit.wikimedia.org/r/142901

Change 141398 had a related patch set uploaded by John Vandenberg:
WIP: Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398

Change 141398 had a related patch set uploaded by John Vandenberg:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398

Change 141398 merged by XZise:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398

jayvdb set Security to None.