Page MenuHomePhabricator
Create Task
Maniphest T69284

claimit.py should add another value but not duplicate
Closed, ResolvedPublic
Actions

Description

When some item have P12=Q1234, claimit.py does not change this value

when using -exists:ptq, script will add new value, but also can create duplicate statement with same value

https://www.wikidata.org/w/index.php?title=Q11723060&diff=141220723&oldid=87098576

See Also:
T72702: claimit and harvest_template - add another value for one property
T57002: claimit.py sample: add option to allow checking for identical statement (same property with same value)

Details

Reference
bz67284
SubjectRepoBranchLines +/-
Fix claimit -exists functionalitypywikibot/coremaster+147 -48
Rewrite claimit.pypywikibot/coremaster+60 -71
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:35 AM
• bzimport added a project: Pywikibot-Wikidata.
• bzimport set Reference to bz67284.
• bzimport added a subscriber: Unknown Object (????).
JAnD created this task.Jun 29 2014, 9:01 PM
JAnD added a comment.Nov 11 2014, 1:28 PM

see also
https://bugzilla.wikimedia.org/show_bug.cgi?id=70702

Aklapper added a project: Pywikibot.Nov 27 2014, 4:14 PM
jayvdb moved this task from Backlog to Data loading problems on the Pywikibot-Wikidata board.Nov 30 2014, 12:09 PM
jayvdb merged a task: T75397: claimit.py should add q to existing property with -exists:pt.Dec 2 2014, 5:19 AM
jayvdb edited subscribers, added: Yamaha5; removed: Unknown Object (????).
jayvdb merged a task: T57002: claimit.py sample: add option to allow checking for identical statement (same property with same value).Dec 2 2014, 6:36 AM
jayvdb mentioned this in T56415: claimit.py: enable claim with the same property, but different value.
jayvdb added subscribers: Legoktm, Strainu.
gerritbot added a project: Patch-For-Review.Dec 2 2014, 3:14 PM

Change 176930 had a related patch set uploaded (by John Vandenberg):
Fix claimit -exists functionality

https://gerrit.wikimedia.org/r/176930

Patch-For-Review

Strainu set Security to None.Apr 15 2015, 7:48 PM
Strainu unsubscribed.
gerritbot subscribed.Dec 27 2016, 3:34 PM

Change 329050 had a related patch set (by Matěj Suchánek) published:
Rewrite claimit.py

https://gerrit.wikimedia.org/r/329050

matej_suchanek updated the task description. (Show Details)Dec 27 2016, 3:35 PM
gerritbot added a comment.Apr 30 2017, 8:12 AM

Change 329050 merged by jenkins-bot:
[pywikibot/core@master] Rewrite claimit.py

https://gerrit.wikimedia.org/r/329050

matej_suchanek edited projects, added TestMe; removed Patch-For-Review.Apr 30 2017, 9:10 AM
matej_suchanek moved this task from Backlog to Needs Review on the Pywikibot board.
matej_suchanek subscribed.

My patch has been merged, now it should be tested that it no longer adds duplicate values.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 30 2017, 9:10 AM
matej_suchanek mentioned this in T72702: claimit and harvest_template - add another value for one property.Jul 11 2017, 7:00 PM
matej_suchanek claimed this task.Aug 8 2017, 10:12 AM
matej_suchanek removed a project: TestMe.
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 8 2017, 10:12 AM
matej_suchanek closed this task as Resolved.Aug 8 2017, 10:13 AM
gerritbot added a comment.Jul 5 2020, 9:21 AM

Change 176930 abandoned by Matěj Suchánek:
[pywikibot/core@master] Fix claimit -exists functionality

Reason:
Things have changed

https://gerrit.wikimedia.org/r/176930

TerraCodes unsubscribed.Jul 5 2020, 8:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL